Add azure key credential param name #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add_azure_key_credential_param_name * 'autorestv3' of https://github.com/Azure/autorest.python: remove dependency on pytest-asyncio 0.10.0, getting latest version now (#737)
lmazuel
reviewed
Aug 4, 2020
lmazuel
reviewed
Aug 4, 2020
lmazuel
reviewed
Aug 4, 2020
autorest/codegen/__init__.py
Outdated
| credential_scopes = [] | ||
| if credential_param_name: | ||
| _LOGGER.warning( | ||
| "You have --credential-param-name passed in and not AzureKeyCredentialPolicy " |
Member
There was a problem hiding this comment.
Let's fail, this is inconsistent
lmazuel
approved these changes
Aug 4, 2020
…into add_azure_key_credential_param_name * 'autorestv3' of https://github.com/Azure/autorest.python: update x-ms-text based on new m4 treating it as an xml property (#734)
iscai-msft
added a commit
that referenced
this pull request
Aug 5, 2020
…into add_azure_mgmt_core_to_setup * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md Add azure key credential param name (#736) update x-ms-text based on new m4 treating it as an xml property (#734) remove dependency on pytest-asyncio 0.10.0, getting latest version now (#737)
iscai-msft
added a commit
that referenced
this pull request
Aug 5, 2020
…into polling_interval_in_doc * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md Add azure key credential param name (#736) update x-ms-text based on new m4 treating it as an xml property (#734)
iscai-msft
added a commit
that referenced
this pull request
Aug 7, 2020
…into verify_multipart * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md Replace not extend scopes (#745) Have either AzureKeyCredential typing or TokenCredential typing (#744) only add polling interval in service client doc if package has lro operations (#732) Add azure mgmt core to setup (#738) Update package.json Update ChangeLog.md Add azure key credential param name (#736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.