only add polling interval in service client doc if package has lro operations #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
commented
Jul 30, 2020
| chosen_parameter.multiple_media_types_type_annot = f"Union[{type_annot}]" | ||
| chosen_parameter.multiple_media_types_docstring_type = docstring_type | ||
|
|
||
| @property |
Contributor
Author
There was a problem hiding this comment.
ideally would've had this code in jinja2, but spent a long time and don't think I can get the jinja2 template to correctly filter by property 'has_lro'. Always defaults to what an Operation model has for this value: False
…into polling_interval_in_doc * 'autorestv3' of https://github.com/Azure/autorest.python: remove dependency on pytest-asyncio 0.10.0, getting latest version now (#737)
lmazuel
approved these changes
Aug 4, 2020
…into polling_interval_in_doc * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md Add azure key credential param name (#736) update x-ms-text based on new m4 treating it as an xml property (#734)
…torest.python into polling_interval_in_doc * 'polling_interval_in_doc' of https://github.com/Azure/autorest.python:
…into polling_interval_in_doc * 'autorestv3' of https://github.com/Azure/autorest.python: Add azure mgmt core to setup (#738)
iscai-msft
added a commit
that referenced
this pull request
Aug 7, 2020
…into verify_multipart * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md Replace not extend scopes (#745) Have either AzureKeyCredential typing or TokenCredential typing (#744) only add polling interval in service client doc if package has lro operations (#732) Add azure mgmt core to setup (#738) Update package.json Update ChangeLog.md Add azure key credential param name (#736)
iscai-msft
added a commit
that referenced
this pull request
Sep 10, 2020
…into add_nullable_to_validation_map * 'autorestv3' of https://github.com/Azure/autorest.python: (41 commits) add 401 -> ClientAuthenticationError to error map (#763) NotImplementedError -> ValueError (#764) Update ChangeLog.md improve API version error (#752) fix warning for BearerTokenCredentialPolicy and no credential scopes (#758) update to 4.15.416 (#761) Update ChangeLog.md remove async suffix (#759) Handle m4 accept header parameter (#748) Multipart (#746) Introduce explode into autorest (#705) update azure-core and msrest versions (#747) Update package.json Update ChangeLog.md Replace not extend scopes (#745) Have either AzureKeyCredential typing or TokenCredential typing (#744) only add polling interval in service client doc if package has lro operations (#732) Add azure mgmt core to setup (#738) Update package.json Update ChangeLog.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #728