Enable the new cancellationToken pattern on non-azure libraries

src/AutoRest.CSharp/LowLevel/Generation/DpgClientWriter.cs

@@ -99,7 +99,8 @@ public void WriteClient()
                         WriteRequestCreationMethod(_writer, method, _client.Fields);
                     }
 
-                    if (_client.ClientMethods.Any(cm => cm.ConvenienceMethod is not null))
+                    // since the non-azure libraries do not have cancellationToken parameters on their convenience methods, we do not need to add the method to convert the cancellationToken to RequestContext
+                    if (Configuration.IsBranded && _client.ClientMethods.Any(cm => cm.ConvenienceMethod is not null))
                     {
                         WriteCancellationTokenToRequestContextMethod();
                     }
@@ -724,13 +725,16 @@ private void WriteCancellationTokenToRequestContextMethod()
 
         private static FormattableString BuildProtocolMethodSummary(MethodSignature methodSignature, LowLevelClientMethod clientMethod, bool async)
         {
-            List<FormattableString> lines = new()
+            var linkForProtocol = Configuration.IsBranded
+                ? "https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/ProtocolMethods.md"
+                : "https://aka.ms/azsdk/net/protocol-methods";
+            List <FormattableString> lines = new()
             {
                 $"[Protocol Method] {methodSignature.SummaryText}",
                 $"<list type=\"bullet\">",
                 $"<item>",
                 $"<description>",
-                $"This <see href=\"https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/ProtocolMethods.md\">protocol method</see> allows explicit creation of the request and processing of the response for advanced scenarios.",
+                $"This <see href={linkForProtocol:L}>protocol method</see> allows explicit creation of the request and processing of the response for advanced scenarios.",
                 $"</description>",
                 $"</item>"
             };

src/AutoRest.CSharp/LowLevel/Output/ConvenienceMethod.cs

@@ -28,7 +28,7 @@ internal record ConvenienceMethod(MethodSignature Signature, IReadOnlyList<Proto
 
         private record RequestContentParameterInfo(CodeWriterDeclaration ContentVariable, FormattableString ContentValue);
 
-        private (IReadOnlyList<FormattableString> ParameterValues, RequestContentParameterInfo? ContentInfo,  CodeWriterDeclaration? SpreadVariable) PrepareConvenienceMethodParameters(CodeWriterDeclaration contextVariable)
+        private (IReadOnlyList<FormattableString> ParameterValues, RequestContentParameterInfo? ContentInfo, CodeWriterDeclaration? SpreadVariable) PrepareConvenienceMethodParameters(CodeWriterDeclaration contextVariable)
         {
             CodeWriterDeclaration? spreadVariable = null;
             var parameters = new List<FormattableString>();
@@ -108,7 +108,11 @@ private Action<CodeWriter> EnsureConvenienceBodyConverter(CodeWriterDeclaration?
         // RequestContext context = FromCancellationToken(cancellationToken);
         private static void WriteCancellationTokenToRequestContext(CodeWriter writer, CodeWriterDeclaration contextVariable)
         {
-            writer.Line($"{Configuration.ApiTypes.RequestContextType} {contextVariable:D} = FromCancellationToken({KnownParameters.CancellationTokenParameter.Name});");
+            // non-branded convenience methods do not have the cancellationToken parameter any more therefore they no longer need this conversion
+            if (Configuration.IsBranded)
+            {
+                writer.Line($"{Configuration.ApiTypes.RequestContextType} {contextVariable:D} = FromCancellationToken({KnownParameters.CancellationTokenParameter.Name});");
+            }
         }
 
         private static void WriteBodyToRequestContent(CodeWriter writer, CodeWriterDeclaration contentVariable, FormattableString requestContentValue)

src/AutoRest.CSharp/LowLevel/Output/ConvenienceMethodOmittingMessage.cs

@@ -12,10 +12,6 @@ private ConvenienceMethodOmittingMessage(string message)
 
         public string Message { get; }
 
-        public static ConvenienceMethodOmittingMessage AnonymousModel = new("The convenience method of this operation is omitted because it is using at least one anonymous model");
-
-        public static ConvenienceMethodOmittingMessage NotConfident = new("The convenience method of this operation is made internal because this operation directly or indirectly uses a low confident type, for instance, unions, literal types with number values, etc.");
-
         public static ConvenienceMethodOmittingMessage NotMeaningful = new("The convenience method is omitted here because it has exactly the same parameter list as the corresponding protocol method");
     }
 }

src/AutoRest.CSharp/LowLevel/Output/OperationMethodChainBuilder.cs

@@ -202,7 +202,7 @@ private ConvenienceMethodGenerationInfo ShouldGenerateConvenienceMethod()
         // If all the corresponding parameters and return types of convenience method and protocol method have the same type, it does not make sense to generate the convenience method.
         private bool IsConvenienceMethodMeaningful()
         {
-            return _orderedParameters.Where(parameter => parameter.Convenience != KnownParameters.CancellationTokenParameter).Any(parameter => !IsParameterTypeSame(parameter.Convenience, parameter.Protocol))
+            return _orderedParameters.Where(parameter => parameter.Protocol != KnownParameters.RequestContext && parameter.Protocol != KnownParameters.RequestContextRequired).Any(parameter => !IsParameterTypeSame(parameter.Convenience, parameter.Protocol))
                 || !_returnType.Convenience.Equals(_returnType.Protocol);
         }
 
@@ -589,10 +589,20 @@ public void AddRequestConditionHeaders(RequestConditionHeaders conditionHeaderFl
 
         public void AddRequestContext()
         {
-            _orderedParameters.Add(new ParameterChain(
-                KnownParameters.CancellationTokenParameter,
-                ShouldRequestContextOptional() ? KnownParameters.RequestContext : KnownParameters.RequestContextRequired,
-                KnownParameters.RequestContext));
+            if (Configuration.IsBranded)
+            {
+                _orderedParameters.Add(new ParameterChain(
+                    KnownParameters.CancellationTokenParameter,
+                    ShouldRequestContextOptional() ? KnownParameters.RequestContext : KnownParameters.RequestContextRequired,
+                    KnownParameters.RequestContext));
+            }
+            else
+            {
+                _orderedParameters.Add(new ParameterChain(
+                    null,
+                    KnownParameters.RequestContext,
+                    KnownParameters.RequestContext));
+            }
         }
 
         private void AddContentTypeRequestParameter(InputParameter operationParameter, IReadOnlyList<string> requestMediaTypes)

src/AutoRest.CSharp/LowLevel/Output/Samples/DpgOperationSample.cs

@@ -400,6 +400,7 @@ public static bool ShouldGenerateShortVersion(LowLevelClient client, LowLevelCli
             if (method.ConvenienceMethod is not null)
             {
                 if (method.ConvenienceMethod.Signature.Parameters.Count == method.ProtocolMethodSignature.Parameters.Count - 1 &&
+                    method.ConvenienceMethod.Signature.Parameters.Count > 0 &&
                     !method.ConvenienceMethod.Signature.Parameters.Last().Type.Equals(typeof(CancellationToken)))
                 {
                     bool allEqual = true;