Enable the new cancellationToken pattern on non-azure libraries#4524
Merged
ArcturusZhang merged 20 commits intoAzure:feature/v3from Apr 15, 2024
Merged
Conversation
ArcturusZhang
requested review from
ArthurMa1978,
JoshLove-msft,
hallipr,
lirenhe and
m-nash
as code owners
ArcturusZhang
force-pushed
the
enable-new-cancellationtoken-pattern
branch
from
691a1ba to
fdce61a
Compare
Member
Author
|
@m-nash @annelo-msft this PR is ready to review |
annelo-msft
reviewed
Apr 3, 2024
annelo-msft
approved these changes
Apr 3, 2024
Contributor
annelo-msft
left a comment
annelo-msft
left a comment
There was a problem hiding this comment.
Approving with regard to the output code, which looks correct to me. I defer to others on the generator implementation.
annelo-msft
reviewed
Apr 8, 2024
ArcturusZhang
commented
Apr 9, 2024
Member
Author
|
The doc changes are distractions, I will extract those changes into a standalone PR and merge it first. |
Member
Author
|
@annelo-msft FYI I updated this PR and now it only contains the change of removing cancellationToken (the other doc link change has been merged in another PR), it should be a lot more clear to review. |
annelo-msft
reviewed
Apr 9, 2024
…ellationtoken-pattern
…ellationtoken-pattern
This comment was marked as outdated.
This comment was marked as outdated.
…ellationtoken-pattern
…ellationtoken-pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4243
Description
Long story short: in non-azure libraries, convenience methods no longer have the parameter
cancellationToken. Customers needing to provide a cancelling context should use the protocol methods instead for advanced scenarios.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?