Skip to content

Validate operation client parameters #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live1206 merged 10 commits into from
Oct 10, 2023
Merged

Validate operation client parameters #3761

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d9ace26
Validate operation client parameters
live1206 Sep 21, 2023
08831fb
ignore case
live1206 Sep 21, 2023
ce2f722
Merge branch 'feature/v3' into validate-operation-parameter
live1206 Sep 22, 2023
9e631bd
Address PR comment
live1206 Sep 22, 2023
0cda417
Merge branch 'validate-operation-parameter' of https://github.com/liv…
live1206 Sep 22, 2023
8bfdc37
update
live1206 Sep 22, 2023
411b57a
minor
live1206 Sep 22, 2023
1d1288f
Merge branch 'feature/v3' into validate-operation-parameter
live1206 Sep 25, 2023
b8d698f
update
live1206 Sep 25, 2023
2426321
Merge branch 'feature/v3' into validate-operation-parameter
live1206 Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/AutoRest.CSharp/Mgmt/Models/MgmtRestClientBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,22 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.

using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO.MemoryMappedFiles;
using System.Linq;
using AutoRest.CSharp.Common.Input;
using AutoRest.CSharp.Generation.Types;
using AutoRest.CSharp.Generation.Writers;
using AutoRest.CSharp.Input;
using AutoRest.CSharp.Mgmt.AutoRest;
using AutoRest.CSharp.Output.Builders;
using AutoRest.CSharp.Output.Models;
using AutoRest.CSharp.Output.Models.Shared;
using AutoRest.CSharp.Output.Models.Types;
using Microsoft.CodeAnalysis.CSharp.Syntax;

namespace AutoRest.CSharp.Mgmt.Models
{
internal class MgmtRestClientBuilder : CmcRestClientBuilder
{
private static HashSet<string> AllowedRequestParameterOrigins = new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "modelerfour:synthesized/host", "modelerfour:synthesized/api-version" };
private class ParameterCompareer : IEqualityComparer<RequestParameter>
{
public bool Equals([AllowNull] RequestParameter x, [AllowNull] RequestParameter y)
Expand All @@ -44,11 +41,23 @@ public MgmtRestClientBuilder(OperationGroup operationGroup)
{
}

public static IEnumerable<RequestParameter> GetMgmtParametersFromOperations(ICollection<Operation> operations) =>
operations
.SelectMany(op => op.Parameters.Concat(op.Requests.SelectMany(r => r.Parameters)))
.Where(p => p.Implementation == ImplementationLocation.Client)
.Distinct(new ParameterCompareer());
private static IReadOnlyList<RequestParameter> GetMgmtParametersFromOperations(ICollection<Operation> operations)
{
var parameters = new HashSet<RequestParameter>(new ParameterCompareer());
foreach (var operation in operations)
{
var clientParameters = operation.Parameters.Where(p => p.Implementation == ImplementationLocation.Client);
foreach (var parameter in clientParameters)
{
if (!AllowedRequestParameterOrigins.Contains(parameter.Origin ?? string.Empty))
{
throw new InvalidOperationException($"'{parameter.Language.Default.Name}' with origin '{parameter.Origin}' should be method parameter for operation '{operation.OperationId}'");
}
parameters.Add(parameter);
}
}
return parameters.ToList();
}

public override Parameter BuildConstructorParameter(RequestParameter requestParameter)
{
Expand Down