Validate operation client parameters#3761
Merged
live1206 merged 10 commits intoAzure:feature/v3from Oct 10, 2023
Merged
Conversation
…e1206/autorest.csharp into validate-operation-parameter
ArcturusZhang
approved these changes
Sep 22, 2023
6 tasks
live1206
requested review from
ArthurMa1978,
hallipr,
jsquire,
lirenhe and
m-nash
as code owners
Member
Author
|
Verified in Azure/azure-sdk-for-net#39149 |
ArthurMa1978
approved these changes
Oct 9, 2023
live1206
added a commit
to live1206/autorest.csharp
that referenced
this pull request
Dec 11, 2023
* Validate operation client parameters * ignore case * Address PR comment * update * minor * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are parameters default as
clientin operations, which is wrong in the first place.Generator does not throw on this, but azure-sdk-for-net code failed to build.
It would be better to fail earlier during generation.