Skip to content

Move pageable helper back to autorest.csharp#3702

Merged
m-nash merged 7 commits intofeature/v3from
mnash-addPageableBack
Aug 30, 2023
Merged

Move pageable helper back to autorest.csharp#3702
m-nash merged 7 commits intofeature/v3from
mnash-addPageableBack

Conversation

@m-nash
Copy link
Member

@m-nash m-nash commented Aug 30, 2023

After this PR #3674 it created a situation where we cannot update the signatures for Pageable helper in back compat way because autorest.csharp opens the signatures but now cannot change them since they live in azure.core.

Temporarily moving this back to unblock serialization work here #3434.

Relies on this merging into main first Azure/azure-sdk-for-net#38399

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on off-line cooperation. This is needed to unblock other efforts, but will need to be addressed in the longer-term to keep shared source unified in Azure.Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants