Move pageable helper back to autorest.csharp#3702
Merged
m-nash merged 7 commits intofeature/v3from Aug 30, 2023
Merged
Conversation
jsquire
approved these changes
Aug 30, 2023
Member
jsquire
left a comment
There was a problem hiding this comment.
Approving based on off-line cooperation. This is needed to unblock other efforts, but will need to be addressed in the longer-term to keep shared source unified in Azure.Core.
annelo-msft
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR #3674 it created a situation where we cannot update the signatures for Pageable helper in back compat way because autorest.csharp opens the signatures but now cannot change them since they live in azure.core.
Temporarily moving this back to unblock serialization work here #3434.
Relies on this merging into main first Azure/azure-sdk-for-net#38399
Description
Add your description here!
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?