Skip to content

Comments

Update serialization code to use new signatures#3434

Closed
m-nash wants to merge 70 commits intofeature/v3from
mnash-generateTestModels
Closed

Update serialization code to use new signatures#3434
m-nash wants to merge 70 commits intofeature/v3from
mnash-generateTestModels

Conversation

@m-nash
Copy link
Member

@m-nash m-nash commented May 24, 2023

Fixes #3181
Fixes #3406
Fixes #3353
Fixes #2351
Fixes Azure/azure-sdk-for-net#16977

Description

This change is a draft to support this issue #3427. We want to generate the models used for testing to avoid any copy paste issues in the serialization code.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash m-nash linked an issue May 24, 2023 that may be closed by this pull request
m-nash added 4 commits July 19, 2023 13:56
@m-nash m-nash mentioned this pull request Jul 20, 2023
6 tasks
@microsoft-github-policy-service
Copy link
Contributor

Hi @m-nash. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@microsoft-github-policy-service
Copy link
Contributor

Hi @m-nash. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DPG Mgmt This issue is related to a management-plane library. no-recent-activity There has been no recent activity on this issue.

Projects

None yet

4 participants