Skip to content

Comments

RequestMethod does not have an implicit to string so needs an explicit call#3609

Merged
m-nash merged 1 commit intofeature/v3from
mnash-fixRequestMethod
Jul 19, 2023
Merged

RequestMethod does not have an implicit to string so needs an explicit call#3609
m-nash merged 1 commit intofeature/v3from
mnash-fixRequestMethod

Conversation

@m-nash
Copy link
Member

@m-nash m-nash commented Jul 19, 2023

Found while working on #3434

If a class doesn't have an implicit to string we need to add .ToString() at the end of the call. RequestMethod does not have this.

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash m-nash merged commit 77c3a1b into feature/v3 Jul 19, 2023
@m-nash m-nash deleted the mnash-fixRequestMethod branch July 19, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants