-
Notifications
You must be signed in to change notification settings - Fork 190
ARM spec adjust #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ARM spec adjust #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase pull request. |
cd5571f to
3866a6c
Compare
m1kola
reviewed
Aug 12, 2021
troy0820
reviewed
Aug 12, 2021
troy0820
reviewed
Aug 12, 2021
...ft.RedHatOpenShift/preview/2021-09-01-preview/examples/OpenShiftClusters_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
troy0820
reviewed
Aug 12, 2021
.../Microsoft.RedHatOpenShift/preview/2021-09-01-preview/examples/OpenShiftClusters_Update.json
Outdated
Show resolved
Hide resolved
|
Please rebase pull request. |
3aad0b4 to
6c7b035
Compare
6c7b035 to
c04fbc1
Compare
ee9e855 to
6338271
Compare
m1kola
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority-medium
Medium priority issue or pull request
question
Further information is requested
ready-for-review
size-medium
Size medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
#1654 MUST GO FIRSTAzure/azure-rest-api-specs#15616 is source of all these changes
This adjust some of the field handling we do for ARM spec to match
What this PR does / why we need it:
ARM validation fails so we need to adjust this a bit.
Test plan for issue:
No
Is there any documentation that needs to be updated for this PR?
No