Set Defaults functionality #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjudeikis
commented
Aug 4, 2021
troy0820
added
priority-medium
Contributor
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
m1kola
reviewed
Aug 5, 2021
pkg/api/v20210901preview/openshiftcluster_validatestatic_test.go
Outdated
Show resolved
Hide resolved
pkg/cluster/defaults_test.go
Outdated
Contributor
Author
There was a problem hiding this comment.
/ // can't use cmp due to cycle imports
Contributor
There was a problem hiding this comment.
Should work if you import from github.com/google/go-cmp/cmp directly instead of using our wrapper.
Contributor
Author
There was a problem hiding this comment.
Not sure I want to do this. This is bigger evil in my book :)
mjudeikis
added
priority-high
m1kola
reviewed
Aug 9, 2021
pkg/api/v20210901preview/openshiftcluster_validatestatic_test.go
Outdated
Show resolved
Hide resolved
pkg/cluster/defaults_test.go
Outdated
Contributor
There was a problem hiding this comment.
Should work if you import from github.com/google/go-cmp/cmp directly instead of using our wrapper.
m1kola
reviewed
Aug 9, 2021
Contributor
m1kola
left a comment
m1kola
left a comment
There was a problem hiding this comment.
Just few nits. Looks good otherwise.
mjudeikis
force-pushed
the
set.defaults
branch
from
930f601 to
c1ff486
Compare
Merged
m1kola
approved these changes
Aug 11, 2021
ross-bryan
pushed a commit
to ross-bryan/ARO-RP
that referenced
this pull request
Sep 24, 2021
ross-bryan
pushed a commit
to ross-bryan/ARO-RP
that referenced
this pull request
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes our ability to serve old cluster using new api
Must merge after #1653
What this PR does / why we need it:
Currently if have a cluster created with old api and we will be doing operations on it using new API this will happen:
""in the documentWith this we making sure that:
adminPutOrPatchcluster document defaults values.Test plan for issue:
Unit tests
Is there any documentation that needs to be updated for this PR?
No