More External Auth validation, tests and some fixes #2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Closed
mociarain
commented
Aug 8, 2025
mociarain
commented
Aug 8, 2025
| } | ||
| }, | ||
| ), | ||
| expectedCSExternalAuth: getBaseCSExternalAuthBuilder().Clients( |
Contributor
Author
There was a problem hiding this comment.
@JameelB These expectedCSExternalAuth represent what we will send to CS
mociarain
commented
Aug 8, 2025
mociarain
requested review from
DennisJWheeler,
Nanyte25,
SudoBrendan,
bennerv,
hbhushan3,
katherinelc321,
kostola,
mbarnes,
oriAdler,
tsatam and
venkateshsredhat
as code owners
mbarnes
requested changes
Aug 8, 2025
Collaborator
mbarnes
left a comment
mbarnes
left a comment
There was a problem hiding this comment.
Looks good for the most part. In the RP-to-CS conversion, I suggest we skip setting builder fields to empty strings.
mbarnes
previously requested changes
Aug 11, 2025
|
a part from the changes above LGTM |
This field is required and therefore will always have a value.
Replaces UsernameClaimPrefixPolicyTypeUnset. This will be the default value.
mbarnes
force-pushed
the
mociarain/external-auth-fixes
branch
from
2050353 to
c69f83f
Compare
mbarnes
force-pushed
the
mociarain/external-auth-fixes
branch
from
c96336c to
d91082a
Compare
|
@mbarnes and @SudoBrendan or @bennerv can this be merged now or is there additional work needed? |
tsatam
approved these changes
Aug 14, 2025
mfreeraro
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces: #2245