Skip to content

Conversation

@Nanyte25
Copy link
Collaborator

Fixing some TODO assign by @mociarain

Why

Special notes for your reviewer

@venkateshsredhat
Copy link
Collaborator

@Nanyte25 To track it in the same PR change the base may be from main branch to @mociarain 's branch .

@Nanyte25
Copy link
Collaborator Author

@mociarain Can you please review these changes, please feel few to close this if you want to make separate commits.

@Nanyte25 Nanyte25 changed the base branch from main to mociarain/external-auth-fe July 24, 2025 08:19
@Nanyte25
Copy link
Collaborator Author

@mociarain I have update the base branch to your external auth. please feel free to review and merge.

@github-actions
Copy link

Please rebase pull request.

@mociarain mociarain force-pushed the mociarain/external-auth-fe branch 4 times, most recently from ef6a325 to 932e68e Compare August 5, 2025 13:51
Base automatically changed from mociarain/external-auth-fe to main August 5, 2025 16:35
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2025

@Nanyte25: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 5c151e9 link true /test images
ci/prow/periodic-images 5c151e9 link true /test periodic-images
ci/prow/stage-e2e-parallel 5c151e9 link false /test stage-e2e-parallel
ci/prow/integration-e2e-parallel 5c151e9 link false /test integration-e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mociarain
Copy link
Contributor

The validation work and unit tests are replaced by: #2426
The E2E work is replaced by: #2376

@mociarain mociarain closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants