-
Notifications
You must be signed in to change notification settings - Fork 104
Pr 2174 #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Nanyte25 To track it in the same PR change the base may be from main branch to @mociarain 's branch . |
|
@mociarain Can you please review these changes, please feel few to close this if you want to make separate commits. |
|
@mociarain I have update the base branch to your external auth. please feel free to review and merge. |
|
Please rebase pull request. |
ef6a325 to
932e68e
Compare
|
@Nanyte25: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixing some TODO assign by @mociarain
Why
Special notes for your reviewer