Skip to content

chore!: update codegened acir parser#631

Closed
TomAFrench wants to merge 7 commits intomasterfrom
update-acir-codegen
Closed

chore!: update codegened acir parser#631
TomAFrench wants to merge 7 commits intomasterfrom
update-acir-codegen

Conversation

@TomAFrench
Copy link
Member

Description

This updates the ACIR parser to match the format as outputted by ACVM 0.21.0

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@TomAFrench TomAFrench requested a review from kevaundray July 26, 2023 09:20
@ludamad
Copy link
Collaborator

ludamad commented Jul 27, 2023

Thanks for porting, hopefully the aztec mirror gets this in properly then this can be closed after

@TomAFrench
Copy link
Member Author

Zero diff after merging in mirrored master so closing this.

@TomAFrench TomAFrench closed this Jul 27, 2023
@TomAFrench TomAFrench deleted the update-acir-codegen branch July 27, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants