feat!: update bberg ACIR parser to target ACVM 0.21.0#1235
Merged
TomAFrench merged 3 commits intomasterfrom Jul 27, 2023
Merged
feat!: update bberg ACIR parser to target ACVM 0.21.0#1235TomAFrench merged 3 commits intomasterfrom
TomAFrench merged 3 commits intomasterfrom
Conversation
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
TomAFrench
force-pushed
the
acvm-0.21.0-compat
branch
from
a5f91c9 to
9a17faf
Compare
Member
|
Merging master to fix stale l1-contracts tag issue |
Collaborator
|
Thinking aloud: Should we create an issue to reinstate bb-bin-test or is it no longer relevant? |
Member
I think so |
Collaborator
|
@TomAFrench mind leaving a bread crumb to this around in the commented out CI tasks? #1236 |
ludamad
reviewed
Jul 27, 2023
| serializer.increase_container_depth(); | ||
| serde::Serializable<decltype(obj.current_witness_index)>::serialize(obj.current_witness_index, serializer); | ||
| serde::Serializable<decltype(obj.opcodes)>::serialize(obj.opcodes, serializer); | ||
| serde::Serializable<decltype(obj.private_parameters)>::serialize(obj.private_parameters, serializer); |
Collaborator
There was a problem hiding this comment.
I'm surprised the decltype pattern is needed here vs deriving the type from the first arg somehow (I guess we'd need a helper function though)
ludamad
approved these changes
Jul 27, 2023
Collaborator
ludamad
left a comment
ludamad
left a comment
There was a problem hiding this comment.
LGTM overall. We really need to come up with a representation of what Noir we target in the repo next (currently a little free-for-all with people bumping noir locally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the ACIR parser to be compatible with the format outputted by the new nargo nightlies.
bb-bin-testshas been disabled as it tests recursion which is not implemented in the new SSA code (and the existing artifacts are incompatible with the new serialisation logic)Mirrors AztecProtocol/barretenberg#631
Checklist: