fix: Include revertdata in Avm simulation errors for failures in nonrevertible#9744
Merged
sirasistant merged 7 commits intomasterfrom Nov 5, 2024
Merged
fix: Include revertdata in Avm simulation errors for failures in nonrevertible#9744sirasistant merged 7 commits intomasterfrom
sirasistant merged 7 commits intomasterfrom
Conversation
sirasistant
changed the title
sirasistant
changed the title
fcarreiro
approved these changes
Nov 5, 2024
Contributor
fcarreiro
left a comment
fcarreiro
left a comment
There was a problem hiding this comment.
LGTM, as we discussed consider (optionally) just adding revertData to SimulationError.
dbanks12
approved these changes
Nov 5, 2024
Contributor
Author
|
Decided to make the regular simulation error have revertdata, since in the future we might have some sort of revertdata in private, for non-string error payloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9727 errors after #9552