Conversation
This was referenced Oct 31, 2024
Contributor
Author
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
75da85e to
b8481ab
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes
branch
from
bb6a3a1 to
4fb64a7
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
b8481ab to
e45714a
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes
branch
from
4fb64a7 to
90b9f43
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
e45714a to
8ada3c6
Compare
Thunkar
approved these changes
Oct 31, 2024
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
8ada3c6 to
d350085
Compare
sklppy88
changed the base branch from
ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes
to
ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles
branch
from
f5f9542 to
e636349
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
d350085 to
f6e4e0f
Compare
Base automatically changed from
ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles
to
master
October 31, 2024 15:29
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
f6e4e0f to
7c33d2a
Compare
sklppy88
force-pushed
the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
from
7c33d2a to
9ffbb33
Compare
sklppy88
deleted the
ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple refactor to use our address book instead of the complete address db (which was used before because we were using registerRecipient as a standin for the address book) when we calculate tags for getting our incoming notes from the node.