feat!: removing register recipient in e2e tests as it is unnecessary now ! by sklppy88 · Pull Request #9499 · AztecProtocol/aztec-packages

sklppy88 · 2024-10-29T03:58:24Z

We no longer need to register public keys to send notes !

Also dealing w/ some comments that have arisen from a previous PR in the stack's diffs showing up

sklppy88 · 2024-10-29T03:58:36Z

feat!: removing register recipient in e2e tests as it is unnecessary now ! #9499 : 2 dependent PRs (#9545 , #9548 ) 👈
fix: remove unnecessary ivpk references in ts #9463 : 1 other dependent PR (#9502 )
fix: replace npk_m_hash with addresses #9461 : 1 other dependent PR (#9495 )
fix: remove unnecessary ivpk's from aztec-nr #9460
refactor: clean up note processor after changes due to address #9401
fix: cleanup of janky encryption apis #9390
feat: implement encryption to an address point and decryption from an address secret #9272
refactor: quick account manager refactor #9357
chore: quick keystore refactor #9355
chore: implement Fq add #9354
feat: introduce default public keys and replace empty public keys #9277
feat: modify private calldata to use public keys #9276
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

benesjan

Looks good. Just looks like some comments need to be updated

benesjan · 2024-10-30T14:47:55Z

yarn-project/circuit-types/src/logs/l1_payload/encrypted_log_payload.ts

   *
   * @param ciphertext - The ciphertext for the log
-   * @param ivsk - The incoming viewing secret key, used to decrypt the logs
+   * @param addressSecret - The incoming viewing secret key, used to decrypt the logs


stale comment

Ah true, thank you, addressed ! 👀

benesjan · 2024-10-30T14:53:28Z

yarn-project/pxe/src/database/deferred_note_dao.ts

 export class DeferredNoteDao {
  constructor(
-    /** IvpkM or OvpkM (depending on if incoming or outgoing) the note was encrypted with. */
+    /** Address Point or OvpkM (depending on if incoming or outgoing) the note was encrypted with. */


Is address point considered a public key? If not then the type and name is out of place here and in other places.

Hmm that is a good point, it is a public key in the basic sense of it, as it is a point that one uses to encrypt a payload with, with a corresponding secret.

But I'm not sure if there was any intention of this specific type to mean something in the context of the protocol. If there was any other meaning besides the basic meaning then I agree it should be changed. If this type is just connoting a public key in the basic sense of the word, then we're golden imo.

benesjan · 2024-10-30T14:58:20Z

yarn-project/pxe/src/note_processor/utils/produce_note_daos.ts

 * @param simulator - An instance of AcirSimulator.
 * @param db - An instance of PxeDatabase.
- * @param ivpkM - The public counterpart to the secret key to be used in the decryption of incoming note logs.
+ * @param addressPoint - The public counterpart to the secret key to be used in the decryption of incoming note logs.


Is this comment true? It's now derived from address only, no?

I think its more accurate to say that the address is derived from the address point, and not vice versa. Although one can recreate zero or two address points from an address, the address point definitely is the point of origin here.

So a better way to look at it maybe is that it all starts from some h and some ivsk. Then the address point is calculated from these, (h + ivsk) * G, or consequently (h * G) + (ivsk * G). Only then is the address taken as the x-coordinate of that point. The address itself needs to stem from the point, and not the other way around, as if it were reversed, we'd never be able to produce the secret.

Therefore for any given valid address point, there will be values (h + ivsk) that are the "secrets" to the point itself. Maybe the wording in the comment above is bad though, so I modified it to be more explicit 🙏

benesjan · 2024-10-30T15:08:17Z

yarn-project/pxe/src/synchronizer/synchronizer.ts

    const publicKeyToIncomingNotes: Map<PublicKey, IncomingNoteDao[]> = new Map();
    for (const noteDao of notes) {
-      const notesForPublicKey = publicKeyToIncomingNotes.get(noteDao.ivpkM) ?? [];
+      const notesForPublicKey = publicKeyToIncomingNotes.get(noteDao.addressPoint) ?? [];


notesForAddressPoint? 😆

Fair, addressed. Thanks for the feedback !

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.62.0</summary> ## [0.62.0](aztec-package-v0.61.0...aztec-package-v0.62.0) (2024-11-01) ### Features * Token private mint optimization ([#9606](#9606)) ([e8fadc7](e8fadc7)) ### Bug Fixes * **k8s:** Boot node long sync ([#9610](#9610)) ([1b85840](1b85840)) * Multi-node metrics working ([#9486](#9486)) ([fd974e1](fd974e1)) * Stop bot in case of tx errors ([#9421](#9421)) ([6650641](6650641)) ### Miscellaneous * Replacing unshield naming with transfer_to_public ([#9608](#9608)) ([247e9eb](247e9eb)) * Token partial notes refactor pt. 1 ([#9490](#9490)) ([3d631f5](3d631f5)) </details> <details><summary>barretenberg.js: 0.62.0</summary> ## [0.62.0](barretenberg.js-v0.61.0...barretenberg.js-v0.62.0) (2024-11-01) ### Features * Faster square roots ([#2694](#2694)) ([722ec5c](722ec5c)) </details> <details><summary>aztec-packages: 0.62.0</summary> ## [0.62.0](aztec-packages-v0.61.0...aztec-packages-v0.62.0) (2024-11-01) ### ⚠ BREAKING CHANGES * **avm:** use 32 bit locations ([#9596](#9596)) * Unique L1 to L2 messages ([#9492](#9492)) ### Features * Add increment secret oracles ([#9573](#9573)) ([97a4c0c](97a4c0c)) * **avm:** Use 32 bit locations ([#9596](#9596)) ([5f38696](5f38696)) * Barebones addressbook for tagging ([#9572](#9572)) ([6526069](6526069)) * Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM size ([#9366](#9366)) ([9211d8a](9211d8a)) * Faster square roots ([#2694](#2694)) ([722ec5c](722ec5c)) * Fixed private log size ([#9585](#9585)) ([755c70a](755c70a)) * Removing register recipient in e2e tests as it is unnecessary now ! ([#9499](#9499)) ([9f52cbb](9f52cbb)) * Reorg test ([#9607](#9607)) ([54488b3](54488b3)) * Simulate validateEpochProofQuoteHeader in the future ([#9641](#9641)) ([284c8f8](284c8f8)) * Spartan proving ([#9584](#9584)) ([392114a](392114a)) * Sync tagged logs ([#9595](#9595)) ([0cc4a48](0cc4a48)) * Token private mint optimization ([#9606](#9606)) ([e8fadc7](e8fadc7)) * Unique L1 to L2 messages ([#9492](#9492)) ([4e5ae95](4e5ae95)), closes [#9450](#9450) ### Bug Fixes * E2e event logs test ([#9621](#9621)) ([737c573](737c573)) * E2e labels ([#9609](#9609)) ([ed1deb9](ed1deb9)) * Ensuring translator range constraint polynomials are zeroes outside of minicircuit ([#9251](#9251)) ([04dd2c4](04dd2c4)) * EventMetadata class implementation for serialisation ([#9574](#9574)) ([bdff73a](bdff73a)) * Force bb-sanitizers true ([#9614](#9614)) ([39cda86](39cda86)) * **k8s:** Boot node long sync ([#9610](#9610)) ([1b85840](1b85840)) * Multi-node metrics working ([#9486](#9486)) ([fd974e1](fd974e1)) * Remove all register recipient functionality in ts ([#9548](#9548)) ([2f7127b](2f7127b)) * Remove unnecessary ivpk references in ts ([#9463](#9463)) ([0c5121f](0c5121f)) * Resolution of bugs from bigfield audits ([#9547](#9547)) ([feace70](feace70)) * Stop bot in case of tx errors ([#9421](#9421)) ([6650641](6650641)) * Typing of artifacts ([#9581](#9581)) ([c71645f](c71645f)) ### Miscellaneous * Add guides to get_e2e_jobs.sh ([#9624](#9624)) ([8891ead](8891ead)) * Add sender to encode and encrypt ([#9562](#9562)) ([8ce6834](8ce6834)) * Add signed int deserialization to decoder ([#9557](#9557)) ([0435d00](0435d00)) * Bb sanitizers on master ([#9564](#9564)) ([747bff1](747bff1)) * Cleaning up token test utils ([#9633](#9633)) ([325bdb0](325bdb0)) * Disable breaking e2e_event_logs test ([#9602](#9602)) ([cf2ca2e](cf2ca2e)) * Dont generate vks for simulated circuits ([#9625](#9625)) ([366eff3](366eff3)) * Fixing broken sample-dapp tests ([#9597](#9597)) ([5e52900](5e52900)) * Nuking `Token::privately_mint_private_note(...)` ([#9616](#9616)) ([bf53f5e](bf53f5e)) * Pass on docker_fast.sh ([#9615](#9615)) ([1c53459](1c53459)) * Remove outgoing tagging field in logs ([#9502](#9502)) ([c473380](c473380)) * Replace relative paths to noir-protocol-circuits ([288099b](288099b)) * Replacing unshield naming with transfer_to_public ([#9608](#9608)) ([247e9eb](247e9eb)) * Token partial notes refactor pt. 1 ([#9490](#9490)) ([3d631f5](3d631f5)) </details> <details><summary>barretenberg: 0.62.0</summary> ## [0.62.0](barretenberg-v0.61.0...barretenberg-v0.62.0) (2024-11-01) ### ⚠ BREAKING CHANGES * **avm:** use 32 bit locations ([#9596](#9596)) ### Features * **avm:** Use 32 bit locations ([#9596](#9596)) ([5f38696](5f38696)) * Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM size ([#9366](#9366)) ([9211d8a](9211d8a)) * Faster square roots ([#2694](#2694)) ([722ec5c](722ec5c)) * Spartan proving ([#9584](#9584)) ([392114a](392114a)) ### Bug Fixes * Ensuring translator range constraint polynomials are zeroes outside of minicircuit ([#9251](#9251)) ([04dd2c4](04dd2c4)) * Resolution of bugs from bigfield audits ([#9547](#9547)) ([feace70](feace70)) ### Miscellaneous * Bb sanitizers on master ([#9564](#9564)) ([747bff1](747bff1)) * Pass on docker_fast.sh ([#9615](#9615)) ([1c53459](1c53459)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.62.0</summary> ## [0.62.0](AztecProtocol/aztec-packages@aztec-package-v0.61.0...aztec-package-v0.62.0) (2024-11-01) ### Features * Token private mint optimization ([#9606](AztecProtocol/aztec-packages#9606)) ([e8fadc7](AztecProtocol/aztec-packages@e8fadc7)) ### Bug Fixes * **k8s:** Boot node long sync ([#9610](AztecProtocol/aztec-packages#9610)) ([1b85840](AztecProtocol/aztec-packages@1b85840)) * Multi-node metrics working ([#9486](AztecProtocol/aztec-packages#9486)) ([fd974e1](AztecProtocol/aztec-packages@fd974e1)) * Stop bot in case of tx errors ([#9421](AztecProtocol/aztec-packages#9421)) ([6650641](AztecProtocol/aztec-packages@6650641)) ### Miscellaneous * Replacing unshield naming with transfer_to_public ([#9608](AztecProtocol/aztec-packages#9608)) ([247e9eb](AztecProtocol/aztec-packages@247e9eb)) * Token partial notes refactor pt. 1 ([#9490](AztecProtocol/aztec-packages#9490)) ([3d631f5](AztecProtocol/aztec-packages@3d631f5)) </details> <details><summary>barretenberg.js: 0.62.0</summary> ## [0.62.0](AztecProtocol/aztec-packages@barretenberg.js-v0.61.0...barretenberg.js-v0.62.0) (2024-11-01) ### Features * Faster square roots ([#2694](AztecProtocol/aztec-packages#2694)) ([722ec5c](AztecProtocol/aztec-packages@722ec5c)) </details> <details><summary>aztec-packages: 0.62.0</summary> ## [0.62.0](AztecProtocol/aztec-packages@aztec-packages-v0.61.0...aztec-packages-v0.62.0) (2024-11-01) ### ⚠ BREAKING CHANGES * **avm:** use 32 bit locations ([#9596](AztecProtocol/aztec-packages#9596)) * Unique L1 to L2 messages ([#9492](AztecProtocol/aztec-packages#9492)) ### Features * Add increment secret oracles ([#9573](AztecProtocol/aztec-packages#9573)) ([97a4c0c](AztecProtocol/aztec-packages@97a4c0c)) * **avm:** Use 32 bit locations ([#9596](AztecProtocol/aztec-packages#9596)) ([5f38696](AztecProtocol/aztec-packages@5f38696)) * Barebones addressbook for tagging ([#9572](AztecProtocol/aztec-packages#9572)) ([6526069](AztecProtocol/aztec-packages@6526069)) * Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM size ([#9366](AztecProtocol/aztec-packages#9366)) ([9211d8a](AztecProtocol/aztec-packages@9211d8a)) * Faster square roots ([#2694](AztecProtocol/aztec-packages#2694)) ([722ec5c](AztecProtocol/aztec-packages@722ec5c)) * Fixed private log size ([#9585](AztecProtocol/aztec-packages#9585)) ([755c70a](AztecProtocol/aztec-packages@755c70a)) * Removing register recipient in e2e tests as it is unnecessary now ! ([#9499](AztecProtocol/aztec-packages#9499)) ([9f52cbb](AztecProtocol/aztec-packages@9f52cbb)) * Reorg test ([#9607](AztecProtocol/aztec-packages#9607)) ([54488b3](AztecProtocol/aztec-packages@54488b3)) * Simulate validateEpochProofQuoteHeader in the future ([#9641](AztecProtocol/aztec-packages#9641)) ([284c8f8](AztecProtocol/aztec-packages@284c8f8)) * Spartan proving ([#9584](AztecProtocol/aztec-packages#9584)) ([392114a](AztecProtocol/aztec-packages@392114a)) * Sync tagged logs ([#9595](AztecProtocol/aztec-packages#9595)) ([0cc4a48](AztecProtocol/aztec-packages@0cc4a48)) * Token private mint optimization ([#9606](AztecProtocol/aztec-packages#9606)) ([e8fadc7](AztecProtocol/aztec-packages@e8fadc7)) * Unique L1 to L2 messages ([#9492](AztecProtocol/aztec-packages#9492)) ([4e5ae95](AztecProtocol/aztec-packages@4e5ae95)), closes [#9450](AztecProtocol/aztec-packages#9450) ### Bug Fixes * E2e event logs test ([#9621](AztecProtocol/aztec-packages#9621)) ([737c573](AztecProtocol/aztec-packages@737c573)) * E2e labels ([#9609](AztecProtocol/aztec-packages#9609)) ([ed1deb9](AztecProtocol/aztec-packages@ed1deb9)) * Ensuring translator range constraint polynomials are zeroes outside of minicircuit ([#9251](AztecProtocol/aztec-packages#9251)) ([04dd2c4](AztecProtocol/aztec-packages@04dd2c4)) * EventMetadata class implementation for serialisation ([#9574](AztecProtocol/aztec-packages#9574)) ([bdff73a](AztecProtocol/aztec-packages@bdff73a)) * Force bb-sanitizers true ([#9614](AztecProtocol/aztec-packages#9614)) ([39cda86](AztecProtocol/aztec-packages@39cda86)) * **k8s:** Boot node long sync ([#9610](AztecProtocol/aztec-packages#9610)) ([1b85840](AztecProtocol/aztec-packages@1b85840)) * Multi-node metrics working ([#9486](AztecProtocol/aztec-packages#9486)) ([fd974e1](AztecProtocol/aztec-packages@fd974e1)) * Remove all register recipient functionality in ts ([#9548](AztecProtocol/aztec-packages#9548)) ([2f7127b](AztecProtocol/aztec-packages@2f7127b)) * Remove unnecessary ivpk references in ts ([#9463](AztecProtocol/aztec-packages#9463)) ([0c5121f](AztecProtocol/aztec-packages@0c5121f)) * Resolution of bugs from bigfield audits ([#9547](AztecProtocol/aztec-packages#9547)) ([feace70](AztecProtocol/aztec-packages@feace70)) * Stop bot in case of tx errors ([#9421](AztecProtocol/aztec-packages#9421)) ([6650641](AztecProtocol/aztec-packages@6650641)) * Typing of artifacts ([#9581](AztecProtocol/aztec-packages#9581)) ([c71645f](AztecProtocol/aztec-packages@c71645f)) ### Miscellaneous * Add guides to get_e2e_jobs.sh ([#9624](AztecProtocol/aztec-packages#9624)) ([8891ead](AztecProtocol/aztec-packages@8891ead)) * Add sender to encode and encrypt ([#9562](AztecProtocol/aztec-packages#9562)) ([8ce6834](AztecProtocol/aztec-packages@8ce6834)) * Add signed int deserialization to decoder ([#9557](AztecProtocol/aztec-packages#9557)) ([0435d00](AztecProtocol/aztec-packages@0435d00)) * Bb sanitizers on master ([#9564](AztecProtocol/aztec-packages#9564)) ([747bff1](AztecProtocol/aztec-packages@747bff1)) * Cleaning up token test utils ([#9633](AztecProtocol/aztec-packages#9633)) ([325bdb0](AztecProtocol/aztec-packages@325bdb0)) * Disable breaking e2e_event_logs test ([#9602](AztecProtocol/aztec-packages#9602)) ([cf2ca2e](AztecProtocol/aztec-packages@cf2ca2e)) * Dont generate vks for simulated circuits ([#9625](AztecProtocol/aztec-packages#9625)) ([366eff3](AztecProtocol/aztec-packages@366eff3)) * Fixing broken sample-dapp tests ([#9597](AztecProtocol/aztec-packages#9597)) ([5e52900](AztecProtocol/aztec-packages@5e52900)) * Nuking `Token::privately_mint_private_note(...)` ([#9616](AztecProtocol/aztec-packages#9616)) ([bf53f5e](AztecProtocol/aztec-packages@bf53f5e)) * Pass on docker_fast.sh ([#9615](AztecProtocol/aztec-packages#9615)) ([1c53459](AztecProtocol/aztec-packages@1c53459)) * Remove outgoing tagging field in logs ([#9502](AztecProtocol/aztec-packages#9502)) ([c473380](AztecProtocol/aztec-packages@c473380)) * Replace relative paths to noir-protocol-circuits ([288099b](AztecProtocol/aztec-packages@288099b)) * Replacing unshield naming with transfer_to_public ([#9608](AztecProtocol/aztec-packages#9608)) ([247e9eb](AztecProtocol/aztec-packages@247e9eb)) * Token partial notes refactor pt. 1 ([#9490](AztecProtocol/aztec-packages#9490)) ([3d631f5](AztecProtocol/aztec-packages@3d631f5)) </details> <details><summary>barretenberg: 0.62.0</summary> ## [0.62.0](AztecProtocol/aztec-packages@barretenberg-v0.61.0...barretenberg-v0.62.0) (2024-11-01) ### ⚠ BREAKING CHANGES * **avm:** use 32 bit locations ([#9596](AztecProtocol/aztec-packages#9596)) ### Features * **avm:** Use 32 bit locations ([#9596](AztecProtocol/aztec-packages#9596)) ([5f38696](AztecProtocol/aztec-packages@5f38696)) * Biggroup_goblin handles points at infinity + 1.8x reduction in ECCVM size ([#9366](AztecProtocol/aztec-packages#9366)) ([9211d8a](AztecProtocol/aztec-packages@9211d8a)) * Faster square roots ([#2694](AztecProtocol/aztec-packages#2694)) ([722ec5c](AztecProtocol/aztec-packages@722ec5c)) * Spartan proving ([#9584](AztecProtocol/aztec-packages#9584)) ([392114a](AztecProtocol/aztec-packages@392114a)) ### Bug Fixes * Ensuring translator range constraint polynomials are zeroes outside of minicircuit ([#9251](AztecProtocol/aztec-packages#9251)) ([04dd2c4](AztecProtocol/aztec-packages@04dd2c4)) * Resolution of bugs from bigfield audits ([#9547](AztecProtocol/aztec-packages#9547)) ([feace70](AztecProtocol/aztec-packages@feace70)) ### Miscellaneous * Bb sanitizers on master ([#9564](AztecProtocol/aztec-packages#9564)) ([747bff1](AztecProtocol/aztec-packages@747bff1)) * Pass on docker_fast.sh ([#9615](AztecProtocol/aztec-packages#9615)) ([1c53459](AztecProtocol/aztec-packages@1c53459)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sklppy88 mentioned this pull request Oct 29, 2024

fix: remove unnecessary ivpk references in ts #9463

Merged

sklppy88 changed the title ~~init~~ feat: e2e 2 pxes no longer requires registering recipient ! Oct 29, 2024

sklppy88 added the e2e-2-pxes label Oct 29, 2024

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch 2 times, most recently from e41c17d to d1f68ea Compare October 29, 2024 04:21

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 879f73c to 9bbb3f7 Compare October 29, 2024 04:22

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from d1f68ea to 9963e49 Compare October 29, 2024 04:44

sklppy88 marked this pull request as ready for review October 29, 2024 04:51

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from 9963e49 to 623d1b2 Compare October 29, 2024 05:06

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 9bbb3f7 to 8d0d8da Compare October 29, 2024 05:06

sklppy88 mentioned this pull request Oct 29, 2024

refactor: remove outgoing tagging field in logs #9502

Merged

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from 623d1b2 to cace047 Compare October 29, 2024 05:51

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 8d0d8da to 5450236 Compare October 29, 2024 05:51

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from cace047 to c24e0ce Compare October 29, 2024 12:22

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 5450236 to ef9a0f2 Compare October 29, 2024 12:22

sklppy88 mentioned this pull request Oct 29, 2024

refactor: remove register recipient as it is unnecessary #9545

Closed

sklppy88 changed the title ~~feat: e2e 2 pxes no longer requires registering recipient !~~ feat: removing register recipient as it is unnecessary now ! Oct 29, 2024

sklppy88 changed the title ~~feat: removing register recipient as it is unnecessary now !~~ feat: removing register recipient in tests as it is unnecessary now ! Oct 29, 2024

sklppy88 changed the title ~~feat: removing register recipient in tests as it is unnecessary now !~~ feat: removing register recipient in e2e tests as it is unnecessary now ! Oct 29, 2024

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from f71e257 to 0425254 Compare October 29, 2024 14:22

sklppy88 mentioned this pull request Oct 29, 2024

fix!: remove all register recipient functionality in ts #9548

Merged

sklppy88 added e2e-all and removed e2e-2-pxes labels Oct 29, 2024

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from c24e0ce to ad1f671 Compare October 30, 2024 00:40

sklppy88 mentioned this pull request Oct 30, 2024

refactor: add sender to encode and encrypt #9562

Merged

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 0425254 to a06e152 Compare October 30, 2024 02:59

sklppy88 mentioned this pull request Oct 30, 2024

feat: adding tags to encrypted logs #9566

Merged

sklppy88 requested a review from benesjan October 30, 2024 03:45

sklppy88 mentioned this pull request Oct 30, 2024

feat: barebones addressbook for tagging #9572

Merged

sklppy88 mentioned this pull request Oct 30, 2024

feat: add increment tagging secret oracles #9573

Merged

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts branch from ad1f671 to e3795e2 Compare October 30, 2024 14:05

benesjan approved these changes Oct 30, 2024

View reviewed changes

Base automatically changed from ek/feat/new-address-scheme-implementation/remove-unnecessary-ivpk-references-in-ts to master October 30, 2024 15:16

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch 2 times, most recently from c216c79 to 43e5664 Compare October 30, 2024 16:05

sklppy88 added 3 commits October 31, 2024 01:20

init

7123c42

init

3cedc85

addressing feedback

6e58f19

sklppy88 force-pushed the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch from 43e5664 to 6e58f19 Compare October 31, 2024 01:22

sklppy88 added e2e-all and removed e2e-all labels Oct 31, 2024

sklppy88 merged commit 9f52cbb into master Oct 31, 2024

sklppy88 deleted the ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient branch October 31, 2024 03:23

AztecBot mentioned this pull request Oct 31, 2024

chore(master): Release 0.62.0 #9583

Merged

sklppy88 changed the title ~~feat: removing register recipient in e2e tests as it is unnecessary now !~~ feat!: removing register recipient in e2e tests as it is unnecessary now ! Oct 31, 2024

sklppy88 mentioned this pull request Oct 31, 2024

feat: use address book in recipient tag calculation #9618

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: removing register recipient in e2e tests as it is unnecessary now !#9499

feat!: removing register recipient in e2e tests as it is unnecessary now !#9499
sklppy88 merged 3 commits intomasterfrom
ek/feat/new-address-scheme-implementation/no-longer-requiring-registration-of-recipient

sklppy88 commented Oct 29, 2024 •

edited

Loading

Uh oh!

sklppy88 commented Oct 29, 2024 •

edited

Loading

Uh oh!

benesjan left a comment

Uh oh!

benesjan Oct 30, 2024

Uh oh!

sklppy88 Oct 30, 2024

Uh oh!

benesjan Oct 30, 2024

Uh oh!

sklppy88 Oct 30, 2024

Uh oh!

benesjan Oct 30, 2024

Uh oh!

sklppy88 Oct 30, 2024

Uh oh!

benesjan Oct 30, 2024

Uh oh!

sklppy88 Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sklppy88 commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sklppy88 commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benesjan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sklppy88 commented Oct 29, 2024 •

edited

Loading

sklppy88 commented Oct 29, 2024 •

edited

Loading