Revert "refactor!: Use circuit builders"#921
Closed
codygunton wants to merge 33 commits intomasterfrom
Closed
Conversation
Weird stuff is happening
* WIP Aztec Sandbox * fix yarn lock * Working zk contract deployment over http Aztec RPC * add expect statements to http test * Remove 'expect' * remove yarn-project build_manifest * Revert project-base dockerfile changes * add missing RPC methods, move http RPC test * move utils to aztec.js & add endpoints to rpc server * move pointToPublicKey to Aztec.js * uniswap test on sandbox * Build system work * lockfile * update rpc for deploymentTx * Fix uniswap sandbox example * CCI Deploy step * fix json rpc server tests * Deploy fix test * Submodule update * Test filter * Updated compose file * Compse file update * CCI fix * Additional compose file * Wait for Ethereum RPC server to become available * Updated CCI config * fix anvil command for docker-compose-fork * Submodule bump * Removed unnecessary dependencies --------- Co-authored-by: PhilWindle <philip.windle@gmail.com>
This reverts commit bef4f57.
Changing test description to reference Schnorr not Ecdsa leads to weird build error.
Contributor
Author
|
I should have selected squash and merge -- sorry, I am used to this being the only option. |
Collaborator
|
If this is due to commit messages, it's best we force push. Someone will need admin access for it. Unfortunately though, a revert would just add one more commit |
suyash67
approved these changes
Jun 28, 2023
ludamad
requested changes
Jun 28, 2023
Collaborator
|
Going on a flight, please double check but I think this new head is now correct: commit 4bd5469 (HEAD -> master, origin/master, origin/HEAD) Flying now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #895