Skip to content

use cross chain harness for uniswap e2e#916

Merged
rahul-kothari merged 1 commit intomasterfrom
rk/uniswap_pp
Jun 27, 2023
Merged

use cross chain harness for uniswap e2e#916
rahul-kothari merged 1 commit intomasterfrom
rk/uniswap_pp

Conversation

@rahul-kothari
Copy link
Copy Markdown
Contributor

@rahul-kothari rahul-kothari commented Jun 27, 2023

Description

Just a refactoring PR -> makes it easier (& quicker) to add the private -> public tests

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

Copy link
Copy Markdown
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rahul-kothari rahul-kothari merged commit a586f3b into master Jun 27, 2023
@rahul-kothari rahul-kothari deleted the rk/uniswap_pp branch June 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants