feat: Capture broadcasted functions in node

[spalladino]

• chore: Bytecode is buffer not string #5351
• docs(yellow-paper): Update function broadcasting functions #5350
• feat: Capture broadcasted unconstrained functions in node #5349
• feat: Capture broadcasted private fns in node #5318
• Deletes isInternal flag from functions in contract classes since it's no longer required by kernel.
• Removes snapshot for contract class generation from artifact

[spalladino]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat: Capture broadcasted functions in node #5353 👈
• chore: Bytecode is buffer not string #5351
• docs(yellow-paper): Update function broadcasting functions #5350
• feat: Capture broadcasted unconstrained functions in node #5349
• feat: Capture broadcasted private fns in node #5318
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 060fa1e1 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,400	6,388	6,424
l1_rollup_execution_gas	585,733	585,721	585,757
l2_block_processing_time_in_ms	1,260 (-3%)	4,647 (-1%)	9,015
note_successful_decrypting_time_in_ms	183 (+2%)	519 (-5%)	1,006
note_trial_decrypting_time_in_ms	90.8 (+11%)	37.7 (-42%)	36.1 (-73%)
l2_block_building_time_in_ms	16,922 (-1%)	63,751 (-1%)	126,112 (-1%)
l2_block_rollup_simulation_time_in_ms	7,875 (-1%)	27,943 (-2%)	54,553 (-1%)
l2_block_public_tx_process_time_in_ms	9,027	35,757	71,467

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,952 (+3%)	27,150 (+3%)
note_history_successful_decrypting_time_in_ms	1,251 (-1%)	2,365 (-5%)
note_history_trial_decrypting_time_in_ms	91.8 (-6%)	118 (+1%)
node_database_size_in_bytes	18,640,976	35,012,688
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	237 (-1%)	44,377	28,214
private-kernel-ordering	211	52,880	14,296
base-parity	4,455	128	311
root-parity	1,567 (-4%)	1,244	311
base-rollup	17,848 (-1%)	165,760	861
root-rollup	49.7	4,359	725
private-kernel-inner	600	73,794	28,214
public-kernel-app-logic	394 (+1%)	35,251	28,217
public-kernel-tail	172 (+1%)	40,928	28,217
merge-rollup	7.59 (-13%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.88 (-1%)	15.8 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.577 (-1%)	0.489 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8 (-3%)	71.0 (-1%)	227 (-2%)	444	850 (-3%)	1,677 (-2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470 (-3%)	0.439 (-1%)	0.415 (-2%)	0.416	0.405 (-3%)	0.402 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.3 (-1%)	106 (-1%)	330 (-2%)	657 (-2%)	1,282 (-3%)	2,556 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.475 (-1%)	0.476 (-1%)	0.450 (-2%)	0.453 (-2%)	0.446 (-3%)	0.444 (-2%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.5 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.531 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,024

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,018 (+1%)	1,623 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	13.2 (-8%)	1,128 (+1%)