Skip to content

chore: Bytecode is buffer not string#5351

Closed
spalladino wants to merge 1 commit intopalla/update-yp-function-broadcastfrom
palla/bytecode-is-buffer
Closed

chore: Bytecode is buffer not string#5351
spalladino wants to merge 1 commit intopalla/update-yp-function-broadcastfrom
palla/bytecode-is-buffer

Conversation

@spalladino
Copy link
Contributor

After deserialization, bytecode should be represented internally as a buffer, not as a b64 string. We actually had several bugs where we were deserializing bytecode as hex instead of b64, which just silently returns an empty buffer because javascript. This PR removes all conversions back and forth between buffer and b64, and just deserializes in the loadContractArtifact function that handles conversion of all noir artifacts.

Copy link
Contributor Author

spalladino commented Mar 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on Graphite Graphite

@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 0bf1666 to 6ac9469 Compare March 22, 2024 12:15
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from 256dae1 to 48d9d55 Compare March 22, 2024 12:15
@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 6ac9469 to 3b98e59 Compare March 22, 2024 12:59
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from 48d9d55 to d71f43a Compare March 22, 2024 12:59
@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 3b98e59 to 92e98de Compare March 22, 2024 14:07
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from d71f43a to c288502 Compare March 22, 2024 14:07
@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 92e98de to 8ff82fe Compare March 22, 2024 15:02
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from c288502 to 3a7caff Compare March 22, 2024 15:02
@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 8ff82fe to 9c3e8fd Compare March 22, 2024 15:40
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from 3a7caff to c5ad8d2 Compare March 22, 2024 15:40
@spalladino spalladino force-pushed the palla/update-yp-function-broadcast branch from 9c3e8fd to 7636803 Compare March 22, 2024 16:59
@spalladino spalladino force-pushed the palla/bytecode-is-buffer branch from c5ad8d2 to 214dea7 Compare March 22, 2024 16:59
@spalladino
Copy link
Contributor Author

Closing in favor of merging everything in one go in #5353

@spalladino spalladino closed this Mar 22, 2024
spalladino added a commit that referenced this pull request Mar 22, 2024
Includes:
- #5351
- #5350
- #5349
- #5318
- And deletes isInternal flag from functions in contract classes since
it's no longer required by kernel.
@ludamad ludamad deleted the palla/bytecode-is-buffer branch August 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants