chore: Bytecode is buffer not string#5351
Closed
spalladino wants to merge 1 commit intopalla/update-yp-function-broadcastfrom
Closed
chore: Bytecode is buffer not string#5351spalladino wants to merge 1 commit intopalla/update-yp-function-broadcastfrom
spalladino wants to merge 1 commit intopalla/update-yp-function-broadcastfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spalladino and the rest of your teammates on |
This was referenced Mar 20, 2024
fcaac51 to
ceb8fbd
Compare
c091ab3 to
49f330f
Compare
ceb8fbd to
0bf1666
Compare
49f330f to
256dae1
Compare
PhilWindle
approved these changes
Mar 22, 2024
0bf1666 to
6ac9469
Compare
256dae1 to
48d9d55
Compare
PhilWindle
approved these changes
Mar 22, 2024
6ac9469 to
3b98e59
Compare
48d9d55 to
d71f43a
Compare
3b98e59 to
92e98de
Compare
d71f43a to
c288502
Compare
92e98de to
8ff82fe
Compare
c288502 to
3a7caff
Compare
8ff82fe to
9c3e8fd
Compare
3a7caff to
c5ad8d2
Compare
9c3e8fd to
7636803
Compare
c5ad8d2 to
214dea7
Compare
Contributor
Author
|
Closing in favor of merging everything in one go in #5353 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After deserialization, bytecode should be represented internally as a buffer, not as a b64 string. We actually had several bugs where we were deserializing bytecode as hex instead of b64, which just silently returns an empty buffer because javascript. This PR removes all conversions back and forth between buffer and b64, and just deserializes in the
loadContractArtifactfunction that handles conversion of all noir artifacts.