refactor: cleanup of prover and verifier instances by lucasxia01 · Pull Request #4959 · AztecProtocol/aztec-packages

lucasxia01 · 2024-03-05T15:42:14Z

Moves the instance_size, log_instance_size, pub_inputs_offset, num_public_inputs, public_inputs out of Prover and VerifierInstance and into the proving key and verification key.

This is a step towards being able to pass only the proving key to the OinkProver (presumcheck prover)

…instance

AztecBot · 2024-03-05T16:16:25Z

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6eb6778c and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,168	239,084	469,772
l1_rollup_execution_gas	194,116	500,390	909,030
l2_block_processing_time_in_ms	1,176 (-1%)	4,472	8,948 (+1%)
note_successful_decrypting_time_in_ms	200 (+2%)	539 (-1%)	998 (+1%)
note_trial_decrypting_time_in_ms	107 (-3%)	55.3 (-17%)	136 (+7%)
l2_block_building_time_in_ms	16,296	65,485 (+1%)	130,111
l2_block_rollup_simulation_time_in_ms	12,384	49,829 (+1%)	99,021
l2_block_public_tx_process_time_in_ms	3,881	15,574 (+1%)	30,968 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,158 (-1%)	26,781 (-3%)
note_history_successful_decrypting_time_in_ms	1,249	2,389 (-1%)
note_history_trial_decrypting_time_in_ms	101 (+5%)	140 (-1%)
node_database_size_in_bytes	18,776,144	35,508,304 (+1%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	252	44,736	28,001
private-kernel-ordering	193 (+1%)	52,625	14,627
base-rollup	1,324 (+1%)	177,932	933
root-rollup	70.3 (-1%)	4,192	825
private-kernel-inner	321 (+1%)	73,715	28,001
public-kernel-app-logic	197 (+1%)	32,254	25,379
merge-rollup	5.75 (+1%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.84	10.4 (+2%)	12.3 (-18%)	16.3 (+1%)	21.9 (-2%)	35.6 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.571	0.578 (+2%)	0.525 (-18%)	0.504 (+1%)	0.458 (-2%)	0.443 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.8	72.2	229	445	864 (-1%)	1,716
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.469	0.446	0.419	0.417	0.412	0.411 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	55.0 (+2%)	106 (-2%)	337 (-1%)	662	1,311	2,623 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.490 (+2%)	0.481 (-1%)	0.457	0.456	0.456 (+1%)	0.454
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.1	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,619	1,377

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0291 (-3%)	481 (+1%)

…instance

…ices with no consequences? from prover_instance

… to verification key)

lucasxia01 · 2024-03-07T16:20:30Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

    auto next_accumulator = std::make_shared<Instance>(accumulator->verification_key);
-    next_accumulator->instance_size = accumulator->instance_size;
-    next_accumulator->log_instance_size = accumulator->log_instance_size;
+    next_accumulator->verification_key = std::make_shared<VerificationKey>(


this needs to be cleaned up (as part of issue 881 I guess), but we initialize the next_accumulator with the accumulator->verification_key and then immediately just create a new verification_key for the next_accumulator...

lucasxia01 · 2024-03-07T16:21:24Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

    if (public_input_size != key->num_public_inputs) {
        return false;
    }
+    if (pub_inputs_offset != key->pub_inputs_offset) {


should these checks also belong in the folding verifier?

there should probably just be an ASSERT there

lucasxia01 · 2024-03-07T16:31:01Z

barretenberg/cpp/src/barretenberg/flavor/goblin_ultra.hpp

     * @todo TODO(https://github.com/AztecProtocol/barretenberg/issues/876)
     */
-    using VerificationKey = VerificationKey_<PrecomputedEntities<Commitment>, VerifierCommitmentKey>;
+    class VerificationKey : public VerificationKey_<PrecomputedEntities<Commitment>, VerifierCommitmentKey> {


Needed a derived class to add the public_inputs in as public_inputs depends on the flavor::FF.

lucasxia01 · 2024-03-07T16:37:02Z

...nberg/cpp/src/barretenberg/stdlib/recursion/honk/verifier/protogalaxy_recursive_verifier.cpp

    auto next_accumulator = std::make_shared<Instance>(builder);
-    next_accumulator->verification_key = accumulator->verification_key;
-    next_accumulator->verification_key->log_circuit_size = accumulator->verification_key->log_circuit_size;
+    next_accumulator->verification_key = std::make_shared<VerificationKey>(


not the best pattern, could probably clean up as next_accumulator->verification_key = accumulator->verification_key in a clarifying state PR

lucasxia01 · 2024-03-07T16:38:02Z

...nberg/cpp/src/barretenberg/stdlib/recursion/honk/verifier/protogalaxy_recursive_verifier.cpp

        expected_parameters.lookup_grand_product_delta +=
            instance->relation_parameters.lookup_grand_product_delta * lagranges[inst_idx];
    }
-


moved to above so that I handle all verification_key stuff together

lucasxia01 · 2024-03-07T16:38:13Z

...etenberg/cpp/src/barretenberg/stdlib/recursion/honk/verifier/recursive_verifier_instance.hpp

        verification_key->pub_inputs_offset = instance->verification_key->pub_inputs_offset;
        verification_key->pcs_verification_key = instance->verification_key->pcs_verification_key;
+        for (auto [public_input, native_public_input] :
+             zip_view(verification_key->public_inputs, instance->verification_key->public_inputs)) {


switch to zip_view

lucasxia01 · 2024-03-07T16:40:05Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.cpp

-    for (size_t i = 0; i < instance->public_inputs.size(); ++i) {
-        auto public_input_i = instance->public_inputs[i];
+    for (size_t i = 0; i < instance->proving_key->public_inputs.size(); ++i) {
+        auto public_input_i = instance->proving_key->public_inputs[i];


maybe unnecessary copying here

lucasxia01 · 2024-03-07T16:40:57Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

        transcript->template receive_from_prover<uint32_t>(domain_separator + "_public_input_size");
-
-    for (size_t i = 0; i < inst->public_input_size; ++i) {
+    inst->verification_key->public_inputs.clear();


need to be cleared to avoid doubling length of public inputs

codygunton · 2024-03-07T18:12:18Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

    if (public_input_size != key->num_public_inputs) {
        return false;
    }
+    if (pub_inputs_offset != key->pub_inputs_offset) {


there should probably just be an ASSERT there

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](#4870)) ([5cccc78](5cccc78)) * Deploying new inbox ([#5036](#5036)) ([fed729d](fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](#5086)) ([6206bec](6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](#4983)) ([480161f](480161f)) * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Nullifier read requests in public kernel ([#4910](#4910)) ([0e44247](0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](#5030)) ([b2af880](b2af880)) * Flaky deployment test ([#5035](#5035)) ([039eafc](039eafc)) * Pull the correct platform image for noir ([#5097](#5097)) ([3342371](3342371)) * Sleep function memory leak ([#5023](#5023)) ([a72cfea](a72cfea)), closes [#4817](#4817) * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](#4966)) ([7ef4ef5](7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](#5034)) ([df089de](df089de)) * Build avm transpiler if we are on mac ([#5039](#5039)) ([c2966b9](c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](#5044)) ([add91ca](add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](#5061)) ([1be9243](1be9243)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Moving RootRollupInputs impl ([#5087](#5087)) ([f3d9f9b](f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](#5076)) ([c255255](c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](AztecProtocol/aztec-packages#4870)) ([5cccc78](AztecProtocol/aztec-packages@5cccc78)) * Deploying new inbox ([#5036](AztecProtocol/aztec-packages#5036)) ([fed729d](AztecProtocol/aztec-packages@fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](AztecProtocol/aztec-packages#5086)) ([6206bec](AztecProtocol/aztec-packages@6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](AztecProtocol/aztec-packages#4983)) ([480161f](AztecProtocol/aztec-packages@480161f)) * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Nullifier read requests in public kernel ([#4910](AztecProtocol/aztec-packages#4910)) ([0e44247](AztecProtocol/aztec-packages@0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](AztecProtocol/aztec-packages#5030)) ([b2af880](AztecProtocol/aztec-packages@b2af880)) * Flaky deployment test ([#5035](AztecProtocol/aztec-packages#5035)) ([039eafc](AztecProtocol/aztec-packages@039eafc)) * Pull the correct platform image for noir ([#5097](AztecProtocol/aztec-packages#5097)) ([3342371](AztecProtocol/aztec-packages@3342371)) * Sleep function memory leak ([#5023](AztecProtocol/aztec-packages#5023)) ([a72cfea](AztecProtocol/aztec-packages@a72cfea)), closes [#4817](AztecProtocol/aztec-packages#4817) * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](AztecProtocol/aztec-packages#4966)) ([7ef4ef5](AztecProtocol/aztec-packages@7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](AztecProtocol/aztec-packages#5034)) ([df089de](AztecProtocol/aztec-packages@df089de)) * Build avm transpiler if we are on mac ([#5039](AztecProtocol/aztec-packages#5039)) ([c2966b9](AztecProtocol/aztec-packages@c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](AztecProtocol/aztec-packages#5044)) ([add91ca](AztecProtocol/aztec-packages@add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](AztecProtocol/aztec-packages#5061)) ([1be9243](AztecProtocol/aztec-packages@1be9243)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Moving RootRollupInputs impl ([#5087](AztecProtocol/aztec-packages#5087)) ([f3d9f9b](AztecProtocol/aztec-packages@f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](AztecProtocol/aztec-packages#5076)) ([c255255](AztecProtocol/aztec-packages@c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

lucasxia01 added 3 commits March 1, 2024 19:02

initial removal

d593dab

Merge remote-tracking branch 'origin/master' into lx/refactor-prover-…

608be8f

…instance

removing instance_size and log_instance_size

63f7737

lucasxia01 marked this pull request as draft March 5, 2024 15:42

lucasxia01 self-assigned this Mar 5, 2024

lucasxia01 added 11 commits March 5, 2024 19:49

fix tests

2d85fa9

Merge remote-tracking branch 'origin/master' into lx/refactor-prover-…

72ab44b

…instance

deleted contains_recursive_proof and recursive_proof_public_input_ind…

7b7a08f

…ices with no consequences? from prover_instance

moved pub_inputs_offset to proving_key

122d8bb

moved pub_inputs_offset to verification key

fa4b73d

using num_public_inputs in PG prover

7e7cd95

using num_public_inputs in verifiers

120f4fb

small edits to ultra prover to remove instance dependence

d0b7262

test fix

8af1286

recursive test fix (forgot to copy pub inputs offset from proving key…

da71719

… to verification key)

moving public_inputs to proving_key

c880a54

lucasxia01 changed the title ~~refactor: cleanup of instances~~ refactor: cleanup of prover and verifier instances Mar 6, 2024

lucasxia01 added 2 commits March 7, 2024 03:01

moved public_inputs to VerificationKey

c8dd650

fixed client ivc (need to clear public inputs in verifier)

ae22dcf

lucasxia01 commented Mar 7, 2024

View reviewed changes

lucasxia01 marked this pull request as ready for review March 7, 2024 16:42

codygunton approved these changes Mar 7, 2024

View reviewed changes

codygunton merged commit f2fdefd into master Mar 7, 2024

codygunton deleted the lx/refactor-prover-instance branch March 7, 2024 18:12

AztecBot mentioned this pull request Mar 7, 2024

chore(master): Release 0.26.6 #5037

Merged

Conversation

lucasxia01 commented Mar 5, 2024 • edited by codygunton Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AztecBot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucasxia01 commented Mar 5, 2024 •

edited by codygunton

Loading

AztecBot commented Mar 5, 2024 •

edited

Loading