feat: Choose constructor method in Contract.deploy

[spalladino]

Adds a new deployWithOpts method to the autogenerated contract typescript interfaces which allows the caller to choose which constructor method to call during deployment. Arguments are type-checked based on the method chosen.

Depends on #4896

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 112 (+108%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit dddc35f3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,168	239,048	470,000
l1_rollup_execution_gas	194,116	500,354	909,258
l2_block_processing_time_in_ms	1,196	4,480	8,972 (+1%)
note_successful_decrypting_time_in_ms	207 (+4%)	543 (+1%)	1,000 (+1%)
note_trial_decrypting_time_in_ms	12.6 (+57%)	64.8 (+12%)	34.3 (-72%)
l2_block_building_time_in_ms	16,501 (+2%)	64,767	130,772 (+1%)
l2_block_rollup_simulation_time_in_ms	12,538 (+2%)	49,265 (+1%)	99,856 (+1%)
l2_block_public_tx_process_time_in_ms	3,928 (+2%)	15,415	30,773

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,860 (+4%)	27,655 (+1%)
note_history_successful_decrypting_time_in_ms	1,258 (+2%)	2,382 (-2%)
note_history_trial_decrypting_time_in_ms	⚠️ 112 (+108%)	133 (+1%)
node_database_size_in_bytes	18,776,144	35,590,224
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	252	44,736	28,001
private-kernel-ordering	193	52,625	14,627
base-rollup	1,321	177,932	933
root-rollup	70.1	4,192	825
private-kernel-inner	321	73,715	28,001
public-kernel-app-logic	196 (-1%)	32,254	25,379
merge-rollup	5.74	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.89 (+1%)	10.7 (-2%)	12.4 (-13%)	16.3 (-2%)	22.5	35.6 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.574 (+1%)	0.595 (-2%)	0.526 (-12%)	0.503 (-1%)	0.469	0.444 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.9	72.4	231	444	871	1,732 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.470	0.446	0.422	0.416	0.415	0.415 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.0	107	336 (-1%)	661 (-1%)	1,312	2,636 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.480	0.484	0.458	0.455 (-1%)	0.456	0.454
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.1	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,655 (+1%)	1,374

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0292 (+4%)	478 (-1%)

[just-mitch]

Just a clarifying question: even if something is flagged noinitcheck, the call will if the instance has not been initialized (and is not in the process of being initialized) right?

[spalladino]

If the instance has not been initialized and the function is flagged noinitcheck, then the call will succeed. So this should be used sparingly, and #4937 removes many of the noinitchecks I added all over the place.

[just-mitch]

Nit: probably helps to include the variable name in the error here.

[spalladino]

Will do in a subsequent PR!