feat(avm-simulator): implement EMITUNENCRYPTEDLOG

[fcarreiro]

• Implements EMITUNENCRYPTEDLOG opcode in the simulator (including event_selector which was previously missing)
• Adds emit_unencrypted_log<T> to avm.nr (the new public context).
  • Observe that this function takes any type T that noir is happy to autoconvert to [Field; N]
  • Observe that it does NOT take an address. Instead the simulator uses context.environment.address. See this thread.
  • This function is tested with fields and raw strings. I think it would also probably work with CompressedString and other serializable types, but I can't test it now due to Brillig problems.
• Updated spec.

Closes #4838.

[fcarreiro]

• chore(avm-simulator): revive field comparison #4957
• chore(vscode): add avm-transpiler to vscode rust-analyzer settings #4952
• chore(avm-simulator): better type env getters #4950
• chore(avm-simulator): test improvements #4946
• feat(avm-simulator): implement EMITUNENCRYPTEDLOG #4926 👈
• chore(avm): nit fixes on message opcodes #4915
• chore(avm-simulator): test cleanup using expect.objectContaining() #4863 : 1 other dependent PR (#4895 )
• chore(avm-transpiler): prefix AVM opcode oracles with avmOpcode #4862
• feat(avm-simulator): implement AVM message opcodes (simulator/transpiler/noir-test) #4852
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e899e56e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,144	238,556	469,040
l1_rollup_execution_gas	194,092	499,862	908,298
l2_block_processing_time_in_ms	1,201 (-1%)	4,524	9,024
note_successful_decrypting_time_in_ms	207 (+2%)	564 (+1%)	1,028 (-1%)
note_trial_decrypting_time_in_ms	15.8 (+47%)	90.7 (+10%)	60.7 (+11%)
l2_block_building_time_in_ms	16,362 (+1%)	70,081 (+8%)	140,670 (+8%)
l2_block_rollup_simulation_time_in_ms	12,417 (+1%)	53,023 (+8%)	106,618 (+7%)
l2_block_public_tx_process_time_in_ms	3,915 (+1%)	16,986 (+10%)	33,931 (+10%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,159 (-1%)	26,183 (-2%)
note_history_successful_decrypting_time_in_ms	1,268 (+1%)	2,452 (+2%)
note_history_trial_decrypting_time_in_ms	114 (+26%)	166 (+19%)
node_database_size_in_bytes	18,804,816	35,332,176
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	259 (+3%)	44,736	28,001
private-kernel-ordering	198 (+3%)	52,625	14,627
base-rollup	1,361 (+3%)	177,932	933
root-rollup	71.1 (+1%)	4,192	825
private-kernel-inner	332 (+4%)	73,715	28,001
public-kernel-app-logic	203 (+4%)	32,254	25,379
merge-rollup	5.88 (+1%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.89	10.4 (-2%)	12.5 (-26%)	16.7 (+2%)	22.0 (-3%)	35.6 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.573	0.575 (-2%)	0.531 (-26%)	0.515 (+2%)	0.460 (-2%)	0.442 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.0	72.3	232	446	870 (-1%)	1,737 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.471	0.445	0.423	0.417	0.413 (-1%)	0.416 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	55.6 (+3%)	108	343	663	1,320	2,629
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.493 (+3%)	0.482	0.461	0.455	0.459	0.457
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.4	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.536	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,612 (-1%)	1,419 (+3%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0348 (+5%)	496 (+4%)

[Maddiaa0]

minor comment, but lgtm!

[fcarreiro]

Merge activity

• Mar 5, 3:43 PM EST: @fcarreiro merged this pull request with Graphite.