test: check that portal address is saved#2641
Merged
Conversation
PhilWindle
approved these changes
Oct 4, 2023
spalladino
pushed a commit
that referenced
this pull request
Oct 4, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Oct 5, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](AztecProtocol/aztec-packages#2639)) ([248be1b](AztecProtocol/aztec-packages@248be1b)) * Multiple pixies 1 Sandbox ([#2492](AztecProtocol/aztec-packages#2492)) ([572d572](AztecProtocol/aztec-packages@572d572)) * Take an optional owner to create the initialization nullifier ([#2647](AztecProtocol/aztec-packages#2647)) ([fefc443](AztecProtocol/aztec-packages@fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](AztecProtocol/aztec-packages#2678)) ([343df30](AztecProtocol/aztec-packages@343df30)) * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) * Removal of setting private data root in kernel prover ([#2671](AztecProtocol/aztec-packages#2671)) ([6a2cc28](AztecProtocol/aztec-packages@6a2cc28)), closes [#778](AztecProtocol/aztec-packages#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](AztecProtocol/aztec-packages#2670)) ([dff396c](AztecProtocol/aztec-packages@dff396c)) * Check that portal address is saved ([#2641](AztecProtocol/aztec-packages#2641)) ([9ebef6e](AztecProtocol/aztec-packages@9ebef6e)) * Fixes in deploy scripts ([#2659](AztecProtocol/aztec-packages#2659)) ([f44568b](AztecProtocol/aztec-packages@f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](AztecProtocol/aztec-packages#2663)) ([027f7ec](AztecProtocol/aztec-packages@027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](AztecProtocol/aztec-packages#2645)) ([805fe18](AztecProtocol/aztec-packages@805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0
pushed a commit
that referenced
this pull request
Oct 6, 2023
This PR adds a test for a change made in 64d5e87 to check that after a contract is deployed with a portal contract address the portal is saved both in `ContractData` and `ExtendedContractData` by the Archiver. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Maddiaa0
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for a change made in 64d5e87 to check that after a contract is deployed with a portal contract address the portal is saved both in
ContractDataandExtendedContractDataby the Archiver.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.