feat: multiple pixies 1 Sandbox by benesjan · Pull Request #2492 · AztecProtocol/aztec-packages

benesjan · 2023-09-25T08:28:46Z

Fixes Multiple RPC's connected to same Sandbox #2460
Sneaked in unrelated name change PXE_SERVICE_BLOCK_POLLING_INTERVAL_MS -> PXE_BLOCK_POLLING_INTERVAL_MS.

Note 1: I created a separate CI task for deploying docker image of pxe so if that task or image is messed up it shouldn't be that big of a deal because it would not affect the sandbox image.
Note 2: Instead of SANDBOX_URL env var there are now PXE_URL and AZTEC_NODE_URL. The e2e test automatically uses sandbox if PXE_URL is set. If PXE_URL is set and AZTEC_NODE_URL is not the e2e tests will try to create a client on the same host as PXE but with a port 8079.
Note 3: I needed to expose more methods of the AztecNode via RPC and to do that I had to implement serialization functionality of L1 message with index type.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

…/AztecProtocol/aztec-packages into janb/multiple-rpc-servers-1-node

socket-security · 2023-10-03T08:25:02Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@types/lodash.isequal	4.5.6	None	`+0`	3.8 kB	types

…oL2MessagesTreePath' via RPC

spypsy · 2023-10-03T16:47:07Z

.circleci/config.yml

+      - *setup_env
+      - run:
+          name: "Build and test"
+          command: force_deploy_build pxe-base false


not sure you'll need the -base step, you may want to take a look at #2645

yarn-project/aztec-node/src/aztec-node/http_rpc_server.ts

yarn-project/aztec-sandbox/src/bin/index.ts

yarn-project/aztec-sandbox/src/server.ts

Co-authored-by: spypsy <spypsy@users.noreply.github.com>

yarn-project/types/src/logs/l2_block_l2_logs.ts

spypsy

Makes sense to me, might wanna co-ordinate with the other PR referenced regarding CI process to get the dockerhub publishing going

…/AztecProtocol/aztec-packages into janb/multiple-rpc-servers-1-node

PhilWindle · 2023-10-04T07:06:55Z

.circleci/config.yml

+      - *setup_env
+      - run:
+          name: "Build and test"
+          command: force_deploy_build pxe false x86_64


This script is abot to be removed. You will need to check the above PR to see the new pattern of arch specific builds

PhilWindle · 2023-10-04T07:11:10Z

.circleci/config.yml

          command: yarn-project/deploy_npm.sh

-  deploy-dockerhub:
+  deploy-dockerhub-sandbox:


If you have a look at the deploy_npm step, it recently changed to call a single script in yarn-project which deploys all of the relevant packages.. Could we make the deploy_dockerhub step similar to that?

Will send a new PR.

Addresses Phil's [feedback](#2492 (comment)) on already merged PR.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](AztecProtocol/aztec-packages#2639)) ([248be1b](AztecProtocol/aztec-packages@248be1b)) * Multiple pixies 1 Sandbox ([#2492](AztecProtocol/aztec-packages#2492)) ([572d572](AztecProtocol/aztec-packages@572d572)) * Take an optional owner to create the initialization nullifier ([#2647](AztecProtocol/aztec-packages#2647)) ([fefc443](AztecProtocol/aztec-packages@fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](AztecProtocol/aztec-packages#2678)) ([343df30](AztecProtocol/aztec-packages@343df30)) * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) * Removal of setting private data root in kernel prover ([#2671](AztecProtocol/aztec-packages#2671)) ([6a2cc28](AztecProtocol/aztec-packages@6a2cc28)), closes [#778](AztecProtocol/aztec-packages#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](AztecProtocol/aztec-packages#2670)) ([dff396c](AztecProtocol/aztec-packages@dff396c)) * Check that portal address is saved ([#2641](AztecProtocol/aztec-packages#2641)) ([9ebef6e](AztecProtocol/aztec-packages@9ebef6e)) * Fixes in deploy scripts ([#2659](AztecProtocol/aztec-packages#2659)) ([f44568b](AztecProtocol/aztec-packages@f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](AztecProtocol/aztec-packages#2663)) ([027f7ec](AztecProtocol/aztec-packages@027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](AztecProtocol/aztec-packages#2645)) ([805fe18](AztecProtocol/aztec-packages@805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](AztecProtocol/aztec-packages@barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](AztecProtocol/aztec-packages#2591)) ([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)), closes [#2445](AztecProtocol/aztec-packages#2445) * Make target architecture configurable, target westmere in GA. ([#2660](AztecProtocol/aztec-packages#2660)) ([3cb9639](AztecProtocol/aztec-packages@3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

1. Fixes #2460 2. Sneaked in unrelated name change `PXE_SERVICE_BLOCK_POLLING_INTERVAL_MS` -> `PXE_BLOCK_POLLING_INTERVAL_MS`. **Note 1**: I created a separate CI task for deploying docker image of pxe so if that task or image is messed up it shouldn't be that big of a deal because it would not affect the sandbox image. **Note 2**: Instead of `SANDBOX_URL` env var there are now `PXE_URL` and `AZTEC_NODE_URL`. The e2e test automatically uses sandbox if `PXE_URL` is set. If `PXE_URL` is set and `AZTEC_NODE_URL` is not the e2e tests will try to create a client on the same host as PXE but with a port 8079. **Note 3**: I needed to expose more methods of the AztecNode via RPC and to do that I had to implement serialization functionality of L1 message with index type.

Addresses Phil's [feedback](#2492 (comment)) on already merged PR.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.8.2</summary> ## [0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2) (2023-10-04) ### Features * Constrain return notes from oracle call. ([#2639](#2639)) ([248be1b](248be1b)) * Multiple pixies 1 Sandbox ([#2492](#2492)) ([572d572](572d572)) * Take an optional owner to create the initialization nullifier ([#2647](#2647)) ([fefc443](fefc443)) ### Bug Fixes * Add missing properties to deployed packages ([#2678](#2678)) ([343df30](343df30)) * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) * Removal of setting private data root in kernel prover ([#2671](#2671)) ([6a2cc28](6a2cc28)), closes [#778](#778) ### Miscellaneous * 1 deploy_dockerhub CI task ([#2670](#2670)) ([dff396c](dff396c)) * Check that portal address is saved ([#2641](#2641)) ([9ebef6e](9ebef6e)) * Fixes in deploy scripts ([#2659](#2659)) ([f44568b](f44568b)) * Measure circuit simulation times and input/output sizes ([#2663](#2663)) ([027f7ec](027f7ec)) * Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. ([#2645](#2645)) ([805fe18](805fe18)) </details> <details><summary>barretenberg.js: 0.8.2</summary> ## [0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2) (2023-10-04) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.8.2</summary> ## [0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2) (2023-10-04) ### Bug Fixes * Include ignition data in package or save after 1st download ([#2591](#2591)) ([d5e9f8b](d5e9f8b)), closes [#2445](#2445) * Make target architecture configurable, target westmere in GA. ([#2660](#2660)) ([3cb9639](3cb9639)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan marked this pull request as draft September 25, 2023 08:28

benesjan added 2 commits September 25, 2023 11:27

WIP

f1ac5b1

docs fix

4d5ffa3

benesjan force-pushed the janb/multiple-rpc-servers-1-node branch from ead1ebe to 4d5ffa3 Compare September 25, 2023 12:30

benesjan added 2 commits October 2, 2023 07:03

Merge branch 'master' into janb/multiple-rpc-servers-1-node

74e52cf

fixes after merge

96d2c0b

benesjan changed the title ~~feat: multiple Aztec RPC Servers 1 Sandbox~~ feat: multiple pixies 1 Sandbox Oct 2, 2023

benesjan added 7 commits October 2, 2023 08:24

renaming env vars

0c41bf9

updated sandbox configuration

3f42e5b

Merge branch 'master' into janb/multiple-rpc-servers-1-node

73584fa

chore: exposing aztec node port in dockerfile

7f1085d

Merge branch 'janb/multiple-rpc-servers-1-node' of https://github.com…

e8d68fb

…/AztecProtocol/aztec-packages into janb/multiple-rpc-servers-1-node

updated tests

9dc1588

Merge branch 'master' into janb/multiple-rpc-servers-1-node

b60cde0

benesjan force-pushed the janb/multiple-rpc-servers-1-node branch from 5790652 to b60cde0 Compare October 2, 2023 14:30

benesjan added 5 commits October 2, 2023 14:35

fix

5ab8488

pxe dockerhub deploy

73cacfd

Merge branch 'master' into janb/multiple-rpc-servers-1-node

8ee3b62

linter fix

2a60ab4

equality fix

8256e62

benesjan added 9 commits October 3, 2023 09:22

feat: exposing 'getDataTreePath', 'getL1ToL2MessageAndIndex', 'getL1T…

5f953fc

…oL2MessagesTreePath' via RPC

test: making e2e_2_pxes compatible with sandbox

b581220

renaming SANDBOX_URL as PXE_URL

853af1d

removed unused file

bbed19f

dockerfile cleanup

a501a90

formatting

7eafdec

Merge branch 'master' into janb/multiple-rpc-servers-1-node

c10f7f8

fixes

ce0478f

Merge branch 'master' into janb/multiple-rpc-servers-1-node

04d06ae

fix

9325719

benesjan force-pushed the janb/multiple-rpc-servers-1-node branch from db00efe to 9325719 Compare October 3, 2023 13:15

benesjan added 3 commits October 3, 2023 13:18

better env name

463df43

Merge branch 'master' into janb/multiple-rpc-servers-1-node

22debdc

test fix

26660eb

benesjan marked this pull request as ready for review October 3, 2023 14:18

fixes

26b6e8e

spypsy reviewed Oct 3, 2023

View reviewed changes

yarn-project/aztec-node/src/aztec-node/http_rpc_server.ts Show resolved Hide resolved

spypsy reviewed Oct 3, 2023

View reviewed changes

yarn-project/aztec-sandbox/src/bin/index.ts Outdated Show resolved Hide resolved

spypsy reviewed Oct 3, 2023

View reviewed changes

yarn-project/aztec-sandbox/src/server.ts Show resolved Hide resolved

Update yarn-project/aztec-sandbox/src/bin/index.ts

8c9a37b

Co-authored-by: spypsy <spypsy@users.noreply.github.com>

spypsy reviewed Oct 3, 2023

View reviewed changes

yarn-project/types/src/logs/l2_block_l2_logs.ts Show resolved Hide resolved

spypsy approved these changes Oct 3, 2023

View reviewed changes

benesjan added 3 commits October 4, 2023 06:53

docs fix

5aed56c

Merge branch 'master' into janb/multiple-rpc-servers-1-node

552150a

Merge branch 'janb/multiple-rpc-servers-1-node' of https://github.com…

a828c76

…/AztecProtocol/aztec-packages into janb/multiple-rpc-servers-1-node

benesjan enabled auto-merge (squash) October 4, 2023 07:02

benesjan merged commit 572d572 into master Oct 4, 2023

benesjan deleted the janb/multiple-rpc-servers-1-node branch October 4, 2023 07:15

AztecBot mentioned this pull request Oct 4, 2023

chore(master): Release 0.8.2 #2669

Merged

PhilWindle requested changes Oct 4, 2023

View reviewed changes

This was referenced Oct 4, 2023

chore: Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. #2645

Merged

chore: 1 deploy_dockerhub CI task #2670

Merged

benesjan added a commit that referenced this pull request Oct 4, 2023

chore: 1 deploy_dockerhub CI task (#2670)

dff396c

Addresses Phil's [feedback](#2492 (comment)) on already merged PR.

Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023

chore: 1 deploy_dockerhub CI task (#2670)

ddc154a

Addresses Phil's [feedback](#2492 (comment)) on already merged PR.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: multiple pixies 1 Sandbox#2492

feat: multiple pixies 1 Sandbox#2492
benesjan merged 34 commits intomasterfrom
janb/multiple-rpc-servers-1-node

benesjan commented Sep 25, 2023 •

edited

Loading

Uh oh!

socket-security bot commented Oct 3, 2023

Uh oh!

spypsy Oct 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spypsy left a comment

Uh oh!

PhilWindle Oct 4, 2023

Uh oh!

PhilWindle Oct 4, 2023

Uh oh!

benesjan Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benesjan commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist:

Uh oh!

socket-security bot commented Oct 3, 2023

Uh oh!

spypsy Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spypsy left a comment

Choose a reason for hiding this comment

Uh oh!

PhilWindle Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

PhilWindle Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

benesjan Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benesjan commented Sep 25, 2023 •

edited

Loading