Conversation
…21880) ## Summary - Adds `many_from_buffer_exact<T>` helper in `file_io.hpp` that validates buffer sizes are exact multiples of `sizeof(T)` before deserializing, producing clear error messages for misaligned buffers. - Uses `many_from_buffer_exact` for UltraHonk proof and public inputs binary deserialization in `api_ultra_honk.cpp`. - Adds unit tests verifying rejection of trailing bytes and acceptance of aligned buffers. ClaudeBox log: https://claudebox.work/s/339cddebbe6e2d8c?run=1
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
1 similar comment
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
In the bigfield function `is_less_than` we range constrain the last limb to fit in `NUM_LAST_LIMB_BITS`, this is a stricter range constraint than the one used previously.
## Summary `copy_cross.sh` runs `llvm-strip-20` on all cross-compiled binaries (including macOS) after they were already code-signed by `inject_version` in `bootstrap.sh`. Stripping modifies the binary content, which invalidates the ad-hoc code signature applied by `ldid -S`. This adds a re-signing step with `ldid -S` for macOS Mach-O binaries after stripping, matching the pattern already used in `inject_version`.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add many_from_buffer_exact for strict buffer size validation (#21880)
chore!: Make
is_less_thanrange-check stricter (#21723)fix: re-sign macOS binaries after stripping in copy_cross.sh (#21893)
END_COMMIT_OVERRIDE