feat: add many_from_buffer_exact for strict buffer size validation#21880
Merged
ludamad merged 2 commits intomerge-train/barretenbergfrom Mar 22, 2026
Merged
feat: add many_from_buffer_exact for strict buffer size validation#21880ludamad merged 2 commits intomerge-train/barretenbergfrom
ludamad merged 2 commits intomerge-train/barretenbergfrom
Conversation
Adds many_from_buffer_exact<T> which validates that binary buffer sizes are exact multiples of sizeof(T) before deserializing, giving clear error messages when files have trailing bytes. Applied to UltraHonk proof and public inputs deserialization.
AztecBot
added
ci-draft
ludamad
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
many_from_buffer_exact<T>helper infile_io.hppthat validates buffer sizes are exact multiples ofsizeof(T)before deserializing, producing clear error messages for misaligned buffers.many_from_buffer_exactfor UltraHonk proof and public inputs binary deserialization inapi_ultra_honk.cpp.ClaudeBox log: https://claudebox.work/s/339cddebbe6e2d8c?run=1