fix(sequencer): backport wall-clock time for slot estimation to v4-next (#21769)#21847
Merged
spalladino merged 3 commits intobackport-to-v4-next-stagingfrom Mar 20, 2026
Merged
Conversation
Adapted PR #21769 changes for v4-next: - Resolved conflicts in epoch_cache.ts (kept v4-next 'now' naming, added getNextL1SlotTimestamp) - Resolved conflicts in rollup.ts (renamed canProposeAtNextEthBlock to canProposeAt with timestamp param) - Resolved conflicts in sequencer-publisher.ts (added dateProvider, wall-clock-based timestamp) - Resolved conflicts in sequencer-publisher.test.ts (added EmptyL1RollupConstants mock) - Updated all callers of renamed methods (sequencer.ts, sequencer.test.ts, e2e tests)
- Use dateProvider.nowInSeconds() instead of removed this.nowInSeconds() in epoch_cache - Remove publisher rotation test block (feature not present on v4-next) - Remove stray conflict marker in test file
AztecBot
added
ci-draft
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spalladino
approved these changes
Mar 20, 2026
spalladino
merged commit 026e17b
into
backport-to-v4-next-staging
26 of 29 checks passed
AztecBot
added a commit
that referenced
this pull request
Mar 21, 2026
BEGIN_COMMIT_OVERRIDE chore: backport #21754 (feat!: make isContractInitialized a tri-state enum) to v4-next (#21792) fix(stdlib): zero-pad bufferFromFields when declared length exceeds payload (#21802) test(protocol-contracts): verify max-size bytecode fits in contract class log (#21818) chore: port P2P mesh topic deflake fix to v4-next (#21825) fix(archiver): throw on duplicate contract class or instance additions (#21799) feat: sync poseidon in the browser (#21833) chore: backport #21824 (fix(aztec-up): add sensible defaults to installer y/n prompts) to v4-next (#21844) fix(sequencer): backport wall-clock time for slot estimation to v4-next (#21769) (#21847) chore: backport PR #21788 (feat(p2p): add tx validation for contract class id verification) to v4-next (#21852) feat: sync poseidon browser (#21851) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21769 to v4-next.
When an Ethereum slot is missed (no block produced), the next L1 block lands 24+ seconds after the previous one instead of 12. Computing the next block timestamp as
getBlock().timestamp + ethereumSlotDurationproduces wrong results, causing incorrect L2 slot, committee, and proposer calculations.This backport replaces all
getBlock().timestamp + ethereumSlotDurationpatterns with a newgetNextL1SlotTimestamp()helper that rounds wall-clock time up to the next L1 slot boundary. Additionally,getSyncedL2SlotNumbernow uses the latest synced checkpoint slot as a second signal to determine sync progress.Changes from original PR adapted for v4-next
getTargetEpochAndSlotInNextL1Slot(pipelining not present on v4-next)dateProvider.nowInSeconds()directly instead of removedEpochCache.nowInSeconds()methodcanProposeAtNextEthBlocktocanProposeAton RollupContract and SequencerPublisherFixes #14766
ClaudeBox log: https://claudebox.work/s/76e2a4f0177d755a?run=1