fix: update nullifier non-inclusion test expectations after early oracle throw#21600
Merged
nchamo merged 1 commit intomerge-train/fairiesfrom Mar 16, 2026
Merged
Conversation
nchamo
commented
Mar 16, 2026
| let post_value = MockStruct { a: 3, b: 4 }; | ||
|
|
||
| let sdc = ScheduledDelayChange::<0u64>::new(Option::some(1), Option::some(50), 2); | ||
| let sdc = ScheduledDelayChange::<0_u64>::new(Option::some(1), Option::some(50), 2); |
Contributor
Author
There was a problem hiding this comment.
The formatter kept changing this locally for me
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
added a commit
that referenced
this pull request
Mar 16, 2026
AztecBot
added a commit
that referenced
this pull request
Mar 16, 2026
…ns (v4-next) Backport of #21600. Updates 5 should_fail_with test expectations from "Proving nullifier non-inclusion failed" to "Cannot prove nullifier non-inclusion".
AztecBot
added a commit
that referenced
this pull request
Mar 16, 2026
…ns (v4-next) Backport of #21600. Updates 5 should_fail_with test expectations from "Proving nullifier non-inclusion failed" to "Cannot prove nullifier non-inclusion".
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
BEGIN_COMMIT_OVERRIDE feat: add public log filtering by tag (#21561) feat: default to kernelless simulations (#21575) fix(aztec-node): throw on existing nullifier in getLowNullifierMembershipWitness (#21472) fix: update nullifier non-inclusion test expectations after early oracle throw (#21600) refactor(pxe): type and audit legacy oracle mappings (#21569) END_COMMIT_OVERRIDE
nchamo
pushed a commit
that referenced
this pull request
Mar 17, 2026
…ns (v4-next) Backport of #21600. Updates 5 should_fail_with test expectations from "Proving nullifier non-inclusion failed" to "Cannot prove nullifier non-inclusion".
Contributor
|
that PR of mine just got backported so re-applied the backport label here - should succeed now |
Collaborator
|
❌ Failed to cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should_fail_withtest expectations from"Proving nullifier non-inclusion failed"to"Cannot prove nullifier non-inclusion"0u64->0_u64)Context
PR #21472 changed
getLowNullifierMembershipWitnessin the aztec-node to throw a descriptive error early when a nullifier already exists in the tree, instead of returning the wrong witness and letting the circuit fail downstream. The new error message is"Cannot prove nullifier non-inclusion: nullifier ... already exists in the tree".The Noir tests still expected the old downstream circuit error
"Proving nullifier non-inclusion failed", causing them to fail with "Test failed with the wrong message".Files changed
noir-projects/aztec-nr/aztec/src/history/nullifier/test.nr(2 tests)noir-projects/aztec-nr/aztec/src/history/note/test.nr(1 test)noir-projects/noir-contracts/contracts/test/test_contract/src/test/deployment_proofs.nr(2 tests)noir-projects/noir-protocol-circuits/crates/types/.../test.nr(nargo fmt)