refactor(pxe): type and audit legacy oracle mappings#21569
refactor(pxe): type and audit legacy oracle mappings#21569nchamo merged 1 commit intomerge-train/fairiesfrom
Conversation
nchamo
added
ci-draft
|
@benesjan , I run Claude a few times and it said that those 5 functions in the description were not being used. I'm not sure how to check exactly, can you guide me through it so that I can check if those are used or not? |
There was a problem hiding this comment.
so that changes to Oracle method signatures produce compile-time errors instead of silently breaking at runtime.
Regarding this ^ note that the change in this PR will not trigger the compile time check because it is being run on the functions on the Oracle class (see here).
But I wonder why do we check about the compile time check here? I thought these mappings are a no-touch zone until v5 at which point we just delete them.
I run Claude a few times and it said that those 5 functions in the description were not being used. I'm not sure how to check exactly, can you guide me through it so that I can check if those are used or not?
Regarding this ^. I accidentally did not delete the legacy callbacks when I unpinned the SponsoredFPC contract (I was checking if there were some only used by SponsoredFPC but I missed these when looking through the table that AI outputted).
But I re-verified with an AI prompt and it told me only aztec_prv_notifyRevertiblePhaseStart is used by SponsoredFPC and not used by any of the other pinned contracts so not sure if your AI output is correct.
But anyway I propose that you also open this PR against v4-next (or backport-to-v4-next-staging) and just see if CI passes. I don't think there is any other better way to verify that.
But would also note that this is relevant only until v5 so I would not worry too much about this as if we have some redundant callback mappings it doesn't matter much.
|
Ok, I created #21607 to make sure those 5 functions were not being used, and the CI passed. So I think we are good to go to merge these changes |
|
✅ Successfully backported to backport-to-v4-next-staging #21453. |
BEGIN_COMMIT_OVERRIDE feat: add public log filtering by tag (#21561) feat: default to kernelless simulations (#21575) fix(aztec-node): throw on existing nullifier in getLowNullifierMembershipWitness (#21472) fix: update nullifier non-inclusion test expectations after early oracle throw (#21600) refactor(pxe): type and audit legacy oracle mappings (#21569) END_COMMIT_OVERRIDE
4 participants
Summary
buildLegacyOracleCallbacks, so that changes to Oracle method signatures produce compile-time errors instead of silently breaking at runtime.privateGetNextAppTagAsSenderprivateGetSenderForTagsprivateSetSenderForTagsutilityCheckNullifierExistsutilityGetRandomFieldCloses F-451