feat: use warn_log_format for discarded messages (backport #21053)#21545
Closed
AztecBot wants to merge 6 commits intobackport-to-v4-next-stagingfrom
Closed
feat: use warn_log_format for discarded messages (backport #21053)#21545AztecBot wants to merge 6 commits intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 6 commits intobackport-to-v4-next-stagingfrom
Conversation
## Summary - Lower `SLASH_INACTIVITY_TARGET_PERCENTAGE` from 0.8 to 0.7 - Disable `SLASH_DUPLICATE_PROPOSAL_PENALTY` and `SLASH_DUPLICATE_ATTESTATION_PENALTY` (set to 0) - Increase `SLASH_GRACE_PERIOD_L2_SLOTS` from 1200 to 8400 - Reduce `perBlockAllocationMultiplier` from 2 to 1.2 ## Test plan - Verify generated config files are updated after running `yarn generate` in relevant packages - Deploy to devnet/testnet and confirm slasher behavior matches new parameters --------- Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
This PR was created because merging `v4` into `v4-next` resulted in conflicts. Please resolve the conflicts and merge this PR to keep `v4-next` up to date. This PR was auto-generated by the `pull-v4-into-v4-next` workflow.
… (with conflicts)
Keep v4-next's simpler structure (no custom message handling) while applying warn_log_format change from the original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21053 to v4-next.
Replaces
debug_log_formatwithwarn_log_formatfor messages that are discarded during processing (undecryptable ciphertext, unrecognized message type IDs). These are situations users should be aware of, so warn-level logging is more appropriate than debug.Conflict Resolution
The cherry-pick conflicted because v4-next has a simpler
process_message.nrwithout custom message handling. Resolution kept v4-next's structure while applying thewarn_log_formatchange:debug_log_format→warn_log_formatfor invalid message from tx (line 42)debug_log_format→warn_log_formatfor unknown msg type id (line 94)Original author: @nchamo
ClaudeBox log: https://claudebox.work/s/d7859f91b737f065?run=1