fix: update example_swap to use new L2ToL1MembershipWitness API#21466
Merged
sklppy88 merged 2 commits intomerge-train/fairiesfrom Mar 13, 2026
Merged
fix: update example_swap to use new L2ToL1MembershipWitness API#21466sklppy88 merged 2 commits intomerge-train/fairiesfrom
sklppy88 merged 2 commits intomerge-train/fairiesfrom
Conversation
sklppy88
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #21231 changed the
computeL2ToL1MembershipWitnessAPI signature from(node, epoch, message)to(node, message, txHash), but theexample_swapdocs example (added in PR #20233) was written against the old API. This caused the merge-train CI to fail withTypeError: Cannot read properties of undefined (reading 'siblingPath')because the function received wrong arguments and returnedundefined.Changes
RollupContractimport and usage (no longer needed to manually compute epoch)computeL2ToL1MembershipWitnesscalls to use new signature:(node, message, txHash)witness.epochNumber) instead of computing manuallyClaudeBox log: https://claudebox.work/s/5eb93c1235ed3384?run=2