fix: complete legacy oracle mappings for all pinned contracts (backport #21404)#21455
Closed
AztecBot wants to merge 3 commits intobackport-to-v4-next-stagingfrom
Closed
fix: complete legacy oracle mappings for all pinned contracts (backport #21404)#21455AztecBot wants to merge 3 commits intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 3 commits intobackport-to-v4-next-stagingfrom
Conversation
Adapted oracle method names to v4-next naming convention (utilityXxx/privateXxx instead of aztec_utl_xxx/aztec_prv_xxx). Kept isProtocolContract import and LEGACY_ORACLE_VERSION check from the original PR.
On v4-next, oracle methods still use the utilityXxx/privateXxx naming convention which matches the pinned contract artifacts directly, so no legacy remappings are needed. The infrastructure is in place for when oracle methods are renamed to the aztec_utl_/aztec_prv_ prefix convention (as has happened on next).
Contributor
|
Closing, this is incorrectly done. The actual backport is #21403. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21404 to v4-next.
isActualProtocolContract(only checked 3 contracts) withisProtocolContract(checks all) for oracle version check skipLEGACY_ORACLE_VERSIONcheck to allow pinned protocol contracts with old oracle versions to work alongside current onesbuildLegacyOracleCallbacksinfrastructure (currently empty on v4-next since oracle methods still use theutilityXxx/privateXxxnaming that matches pinned artifacts)Adaptation notes
On v4-next, oracle methods still use the
utilityXxx/privateXxxnaming convention which matches the pinned contract artifacts directly. Onnext, these were renamed toaztec_utl_xxx/aztec_prv_xxx, which is why the original PR needed extensive legacy mappings. On v4-next, the legacy mappings return an empty object since no remapping is needed yet, but the infrastructure is in place.Commits
utilityXxx/privateXxxnames)legacy_oracle_mappings.tsfor v4-next (empty mappings since names haven't changed)Test plan
./bootstrap.shpasses)ClaudeBox log: https://claudebox.work/s/9f6e5eff95a9d6b9?run=1