Skip to content

chore: backport fairies oracle changes to v4-next#21403

Merged
nventuro merged 14 commits intobackport-to-v4-next-stagingfrom
backporting-fairies-oracle-changes-to-v4
Mar 13, 2026
Merged

chore: backport fairies oracle changes to v4-next#21403
nventuro merged 14 commits intobackport-to-v4-next-stagingfrom
backporting-fairies-oracle-changes-to-v4

Conversation

@benesjan
Copy link
Contributor

Summary

Test plan

  • CI passes on backport branch

🤖 Generated with Claude Code

@benesjan benesjan force-pushed the backporting-fairies-oracle-changes-to-v4 branch from 1d18658 to 7038c9a Compare March 12, 2026 03:51
@benesjan benesjan marked this pull request as draft March 12, 2026 03:52
@benesjan benesjan changed the title chore: backport fairies oracle changes to v4 chore: backport fairies oracle changes to v4-next Mar 12, 2026
@benesjan benesjan marked this pull request as ready for review March 12, 2026 06:08
@benesjan benesjan force-pushed the backporting-fairies-oracle-changes-to-v4 branch 3 times, most recently from cd83706 to 77756a0 Compare March 12, 2026 14:53
@ludamad ludamad force-pushed the backport-to-v4-next-staging branch from 5c50c04 to 4eb8703 Compare March 12, 2026 19:33
nventuro and others added 10 commits March 12, 2026 15:39
This adds the `aztec` namespace prefix to all oracles. We need this for
noir-lang/noir#10105, so that we can get
proper error messages on `nargo` that link to aztec docs.

It also shortens the current prefixes:
- `utility` → `utl`
- `private` → `prv`
- `avmOpcode` → `avm`
- `txe` unchanged

The prefixes only exist as the actual oracle name in the nr <> ts
communication layer, they are not present in the nr code nor ts code. I
actually removed the current prefixes from oracle handler fn (e.g.
`utilityGetBlockNumber` becomes `getBlockNumber`) to reduce verbosity
and repetitiveness, given that those functions already exist in
interfaces that scope the oracles that correspond to that execution
mode.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…rams

PR #21176 added maxNotePackedLen and maxEventSerializedLen parameters to
this oracle. Pinned protocol contracts call with the old 3-param signature,
so the legacy mapping needs an adapter that supplies the frozen default
values (8 and 10 respectively).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nventuro nventuro enabled auto-merge (squash) March 12, 2026 22:21
@nventuro
Copy link
Contributor

CI failed, I think we're missing the relaxed check? This might mean that the cherry picking is incomplete, review carefully.

@benesjan
Copy link
Contributor Author

@nventuro this is not passing now because there is still the pinned version of SponsoredFPC on the branch. Will try to resolve unpinning it.

@benesjan benesjan force-pushed the backporting-fairies-oracle-changes-to-v4 branch from ad398e3 to c32ca93 Compare March 13, 2026 02:54
@AztecBot
Copy link
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/1e10af2d78355654�1e10af2d783556548;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_l1_reorgs.parallel.test.ts "updates L1 to L2 messages changed due to an L1 reorg" (65s) (code: 0) group:e2e-p2p-epoch-flakes

@nventuro nventuro merged commit 5896d58 into backport-to-v4-next-staging Mar 13, 2026
9 checks passed
@nventuro nventuro deleted the backporting-fairies-oracle-changes-to-v4 branch March 13, 2026 03:13
@benesjan
Copy link
Contributor Author

I didn't notice this was set to auto merge and it squashed the commits 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants