Skip to content

fix: bump rate limits in reqresp batch retry test to prevent flaky failures #21375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: merge-train/spartan
Choose a base branch
from
Draft

fix: bump rate limits in reqresp batch retry test to prevent flaky failures #21375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion yarn-project/p2p/src/services/reqresp/reqresp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,13 @@ describe('ReqResp', () => {
it('should stop after max retry attempts', async () => {
const batchSize = 12;
const failedIndices = [10, 11];
nodes = await createNodes(peerScoring, 3);
nodes = await createNodes(peerScoring, 3, {
// Bump rate limits so that passing requests don't hit the real rate limiter
[ReqRespSubProtocol.PING]: {
peerLimit: { quotaTimeMs: 1000, quotaCount: 50 },
globalLimit: { quotaTimeMs: 1000, quotaCount: 50 },
},
});

await startNodes(nodes);
await sleep(500);
Expand Down
Loading