fix: bump rate limits in reqresp batch retry test to prevent flaky failures#21375
Draft
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Draft
fix: bump rate limits in reqresp batch retry test to prevent flaky failures#21375AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #21322 mocked the failing requests (indices 10, 11) to deterministically return
RATE_LIMIT_EXCEEDED, but the passing requests (indices 0-9) still go throughoriginalSendto real peers. With 10 requests split across only 2 peers (~5 each), the responding nodes' GCRA rate limiter (default: 1 per 200ms) kicks in and rate-limits some legitimate requests, causing non-deterministic test failures.Fix: add high rate limit quotas (50 per 1000ms) to the test nodes — the same pattern the adjacent "pinned peer" test already uses.
Test plan
should send a batch request with a pinned peertest which already passes with these rate limitsClaudeBox log: https://claudebox.work/s/ae01953d584e6acc?run=1