fix: respect CPUS env var in browser tests and add flake pattern#21356
Draft
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Draft
fix: respect CPUS env var in browser tests and add flake pattern#21356AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
AztecBot
force-pushed
the
claudebox/fix-merge-train-spartan-ci
branch
from
689d65d to
4278757
Compare
AztecBot
changed the title
AztecBot
force-pushed
the
claudebox/fix-merge-train-spartan-ci
branch
from
4278757 to
c376ade
Compare
AztecBot
changed the title
…browser_prove The browser headless test used os.cpus().length to determine thread count, which sees all host CPUs (128) even when the CI job is limited to 8 CPUs. This causes 16 WASM worker threads to compete for 8 CPUs, leading to resource pressure and intermittent 'Failed to fetch' errors. Now uses the CPUS env var (set by CI) when available, falling back to the previous behavior. Also adds a flake pattern for browser_prove.sh so transient failures get retried instead of hard-failing.
AztecBot
force-pushed
the
claudebox/fix-merge-train-spartan-ci
branch
from
c376ade to
06b1d54
Compare
AztecBot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky
browser_prove.shCI failure on merge-train/spartan (unrelated to #21577).os.cpus().lengthto set thread count, seeing all 128 host CPUs even when the CI job is limited to 8 CPUs. This caused 16 WASM workers to compete for 8 CPUs, leading to intermittentFailed to fetcherrors.CPUSenv var (set by CI) when available.browser_prove.shso transient failures get retried.Analysis
https://gist.github.com/AztecBot/f73630c9d27e92ecb75ff207f5be8d5d
Test plan