refactor(pxe): narrow tryGetPublicKeysAndPartialAddress return type#21214
Draft
AztecBot wants to merge 1 commit intobackport-to-v4-stagingfrom
Draft
refactor(pxe): narrow tryGetPublicKeysAndPartialAddress return type#21214AztecBot wants to merge 1 commit intobackport-to-v4-stagingfrom
AztecBot wants to merge 1 commit intobackport-to-v4-stagingfrom
Conversation
Return only `{ publicKeys, partialAddress }` instead of the full
`CompleteAddress` from the oracle interface, since callers never use
the `address` field from the result.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ludamad
force-pushed
the
backport-to-v4-staging
branch
2 times, most recently
from
9221e1a to
be9b609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21208 to v4.
Cherry-pick required conflict resolution due to method renaming (
utilityprefix) on v4. Applied the return type narrowing (CompleteAddress→{ publicKeys, partialAddress }) while preserving the v4 naming convention.ClaudeBox log: http://ci.aztec-labs.com/88fa6a05e56c8662-1