Skip to content

fix: drop --pid=host from docker_isolate#21081

Merged
ludamad merged 2 commits intomerge-train/spartanfrom
claudebox/c898c0eb1e854669-1
Mar 4, 2026
Merged

fix: drop --pid=host from docker_isolate#21081
ludamad merged 2 commits intomerge-train/spartanfrom
claudebox/c898c0eb1e854669-1

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Mar 3, 2026

--pid=host no longer needed, and was a bit suss
Drop some flakes

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 3, 2026
@AztecBot AztecBot changed the title fix: browser_prove flake — respect CPUS env var and cache server files fix: browser_prove flake — respect CPUS env var for thread count Mar 3, 2026
@AztecBot AztecBot force-pushed the claudebox/c898c0eb1e854669-1 branch from cce8d01 to 50fe487 Compare March 3, 2026 21:40
@AztecBot AztecBot changed the title fix: browser_prove flake — respect CPUS env var for thread count fix: drop --pid=host from docker_isolate, use mktemp for temp dirs Mar 3, 2026
@ludamad ludamad marked this pull request as ready for review March 3, 2026 21:49
@ludamad ludamad requested a review from charlielye as a code owner March 3, 2026 21:49
@AztecBot AztecBot changed the title fix: drop --pid=host from docker_isolate, use mktemp for temp dirs fix: drop --pid=host from docker_isolate, respect CPUS in browser tests Mar 3, 2026
@AztecBot AztecBot force-pushed the claudebox/c898c0eb1e854669-1 branch from 954e8d5 to be5554e Compare March 3, 2026 23:09
@ludamad ludamad changed the title fix: drop --pid=host from docker_isolate, respect CPUS in browser tests fix: drop --pid=host from docker_isolate Mar 3, 2026
@ludamad ludamad enabled auto-merge March 3, 2026 23:12
`--pid=host` no longer needed, and was a bit suss
Drop some flakes

Co-authored-by: ludamad <adam.domurad@gmail.com>
@AztecBot AztecBot force-pushed the claudebox/c898c0eb1e854669-1 branch from ddbcb3f to 87f196c Compare March 3, 2026 23:45
@ludamad ludamad added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
Replace output-$$ with mktemp -d to avoid PID collisions across
docker containers sharing $HOME (without --pid=host, containers
get low PIDs like 7, causing output-7 directory collisions).
@ludamad ludamad enabled auto-merge March 4, 2026 00:59
@ludamad ludamad changed the base branch from next to merge-train/spartan March 4, 2026 01:00
@ludamad ludamad merged commit 9bdfcb6 into merge-train/spartan Mar 4, 2026
19 of 20 checks passed
@ludamad ludamad deleted the claudebox/c898c0eb1e854669-1 branch March 4, 2026 01:13
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2026
BEGIN_COMMIT_OVERRIDE
test: update proving-real test to mbps (#20991)
chore: epoch proving log analyzer (#21033)
chore: update pause script to allow resume (#21032)
feat: price bump for RPC transaction replacement (#20806)
refactor: remove update checker, retain version checks (#20898)
fix: (A-592) p2p client proposal tx collector test (#20998)
refactor: use publishers-per-pod in deployments (#21039)
chore: web3signer refreshes keystore (#21045)
feat(sequencer): set block building limits from checkpoint limits
(#20974)
chore(e2e): fix e2e bot L1 tx nonce reuse (#21052)
feat: Update L1 to L2 message APIs (#20913)
fix: (A-589) epochs l1 reorgs test (#20999)
feat(sequencer): add SEQ_MAX_TX_PER_CHECKPOINT config (#21016)
fix: drop --pid=host from docker_isolate (#21081)
feat: standby mode for prover broker (#21098)
fix(p2p): remove default block handler in favor of block handler
(#21105)
feat(validator): add VALIDATOR_ env vars for independent block limits
(#21060)
refactor(p2p): decouple proposal validators from base class via
composition (#21075)
feat: additional validation in public setup allowlist (onlySelf + null
msg sender) (#21122)
fix: (A-591) aztecProofSubmissionEpochs incorrectly named as
aztecProofSubmissionWindow (#21108)
refactor(sequencer): rename SEQ_GAS_PER_BLOCK_ALLOCATION_MULTIPLIER to
SEQ_PER_BLOCK_ALLOCATION_MULTIPLIER (#21125)
fix: unbound variable in check_doc_references.sh with set -u (#21126)
feat: calldata length validation of public setup function allowlist
(#21139)
fix: include mismatched values in tx metadata validation errors (#21147)
feat: single-node implementation of slash-protection signer (#20894)
feat: Remove non-protocol contracts from public setup allowlist (#21154)
chore: More updated Alpha configuration (#21155)
chore: tally slashing pruning improvements (#21161)
fix: update dependencies (#20997)
fix: omit bigint priceBumpPercentage from IPC config in testbench worker
(#21169)
refactor(p2p): (A-588) maintain sorted array in tx pool instead of
sorting on read (#21079)
fix(p2p): report most severe failure in runValidations (#21185)
fix: use dedicated L1 account for bot bridge resume tests to avoid nonce
race (#21148)
fix: parse error.message in formatViemError (#21163)
fix: bump lighthouse consensus client v7.1.0 -> v8.0.1 (#21170)
chore: code decuplication + refactor (public setup allowlist) (#21200)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants