refactor(p2p): rewrite FileStoreTxCollection with retry, backoff, and shared worker pool#20317
Merged
alexghr merged 4 commits intomerge-train/spartanfrom Feb 11, 2026
Merged
Conversation
Base automatically changed from
pw/tx-pool-v2-integration
to
merge-train/spartan
February 10, 2026 17:20
… shared worker pool Split into two instances (fast/slow) with configurable worker counts, deadline-based expiry, and retry with round-robin and exponential backoff. Each instance has a fixed-size worker pool started via start(). Workers pull entries with priority (fewest attempts first), skip entries in backoff, and remove expired entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PhilWindle
force-pushed
the
pw/filestore-fast-slow
branch
from
df4e2be to
bdb5c82
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
alexghr
approved these changes
Feb 10, 2026
Contributor
alexghr
left a comment
alexghr
left a comment
There was a problem hiding this comment.
We reviewed the code. It looks fine. We'll try to combine the code dealing with pickNextEntry and the one dealing with getBackOffMs into one function
alexghr
approved these changes
Feb 11, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
BEGIN_COMMIT_OVERRIDE chore: Should fix proving benchmarks by reducing committee lag (#20381) chore: standalone forge broadcast wrapper with retry, timeout, and anvil detection (#19824) chore: benchmark tx val (#20227) fix: cloudflare terraform API (#20387) fix: HA e2e test order & retries (#20383) fix: incorporate forge broadcast review feedback (#20390) refactor(p2p): rewrite FileStoreTxCollection with retry, backoff, and shared worker pool (#20317) chore(ci): run ci job on draft PRs (#20395) feat(bot): allow anchoring txs to proposed chain (#20392) feat(p2p): slot-based soft deletion for TxPoolV2 (#20388) chore: add setup-container script (#20309) feat: build aztec-prover-agent with baked-in CRS (#20391) fix!: change protocol contracts deployer to be the contract address (#20396) feat(p2p): enforce minimum tx pool age for block building (#20384) refactor(sentinel): update validator statuses to checkpoint-based naming (#20372) chore: log tx hash (#20413) chore: update l1 fee analysis to measure blob count in L1 blocks (#20414) chore: set up tx file store in next-net (#20418) chore(ci): gate draft PRs from CI, allow override with ci-draft label (#20426) fix: stabilize writing_an_account_contract.test.ts (#20420) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileStoreTxCollectionwith a shared worker pool, deadline-based expiry, and retry with round-robin and exponential backoffgetProofDeadlineForSlotas a public free function fromSlowTxCollectionfor reuseTest plan
file_store_tx_collection.test.tstests pass (updated for new interface, added retry/backoff/deadline/clearPending tests)tx_collection.test.tstests pass (updated for two file store instances)yarn buildsucceeds,yarn format p2pandyarn lint p2pcleanwaitForSourceCalls,waitForTxsAdded) instead of blind sleeps to avoid flakiness🤖 Generated with Claude Code