fix: tmnt 405, 411, 413, 414, 418, 419, 421, 425#17299
Merged
Conversation
This was referenced Sep 25, 2025
Contributor
Author
Merged
LHerskind
force-pushed
the
lh/tmnt-421-spearbit-5-computesampleindex-early-return-if-index-1
branch
from
8b5c7d8 to
66dfec6
Compare
LHerskind
force-pushed
the
lh/tmnt-401-veridise-non-standard-hash-to-curve-implementation
branch
2 times, most recently
from
a9ef2c2 to
adc6fef
Compare
LHerskind
force-pushed
the
lh/tmnt-421-spearbit-5-computesampleindex-early-return-if-index-1
branch
from
66dfec6 to
a3c8c2d
Compare
LHerskind
changed the title
AztecBot
force-pushed
the
lh/tmnt-401-veridise-non-standard-hash-to-curve-implementation
branch
2 times, most recently
from
b9b4d40 to
b02160b
Compare
Base automatically changed from
lh/tmnt-401-veridise-non-standard-hash-to-curve-implementation
to
next
September 25, 2025 22:33
just-mitch
reviewed
Sep 26, 2025
| // Cannot modulo by 0 | ||
| if (_indexCount == 0) { | ||
| // Cannot modulo by 0 and if 1, then only acceptable value is 0 | ||
| if (_indexCount <= 0) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (_indexCount <= 0) { | |
| if (_indexCount <= 1) { |
Contributor
Author
There was a problem hiding this comment.
Sheesh. I'm a moron 💀
just-mitch
approved these changes
Sep 26, 2025
LHerskind
force-pushed
the
lh/tmnt-421-spearbit-5-computesampleindex-early-return-if-index-1
branch
from
a3c8c2d to
70f004d
Compare
LHerskind
deleted the
lh/tmnt-421-spearbit-5-computesampleindex-early-return-if-index-1
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue fixes TMNT: 405, 411, 413, 414, 418, 419, 421, 425