fix: gas boundary and removal of isOnCurve#17249
Merged
Conversation
This was referenced Sep 23, 2025
Contributor
Author
|
just wanted to drop by and say hi. These are real contributions, Mike. |
Contributor
Author
Mike is not in this pr. |
just-mitch
reviewed
Sep 24, 2025
l1-contracts/src/governance/GSE.sol
Outdated
| DepositAndDelegationAccounting internal delegation; | ||
| Governance internal governance; | ||
|
|
||
| // The gas provided for the proof of possession. Should overestimate acceptable happy path |
Collaborator
There was a problem hiding this comment.
The comment here is a little hard to follow. It may also give the reader/auditor confidence to provide the current average gas required so we understand what kind of buffer we have.
Contributor
Author
There was a problem hiding this comment.
Will look at making it more clear 👍
just-mitch
approved these changes
Sep 24, 2025
Collaborator
just-mitch
left a comment
just-mitch
left a comment
There was a problem hiding this comment.
🎉 Amazing!!! I'm so glad you were able to crack this one cleanly. I can't believe the call needed to be external to do it, but a small price to pay.
LHerskind
force-pushed
the
lh/tmnt-394-veridise-maintainability
branch
from
b0327f5 to
a310dd9
Compare
LHerskind
force-pushed
the
lh/tmnt-395-veridise-missing-curve-order-checks-may-lead-to-malleability
branch
from
bcf1b75 to
5cd8f41
Compare
This was referenced Sep 25, 2025
Merged
Base automatically changed from
lh/tmnt-394-veridise-maintainability
to
next
September 25, 2025 15:19
LHerskind
deleted the
lh/tmnt-395-veridise-missing-curve-order-checks-may-lead-to-malleability
branch
This was referenced Sep 26, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.