Conversation
* Define methods to mock proofs for translator and eccvm * Restructure functions to create dummy vk and proofs in recursion constraints so that they use the functions from `mock_verifier_inputs` (this avoids code duplication) This PR is mostly in preparation for transitioning the tube in noir. We need to mock translator and eccvm proofs to mock ClientIVC proofs. --------- Co-authored-by: AztecBot <tech@aztecprotocol.com>
✅ Deploy Preview for barretenberg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for aztec-docs-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
We have drifted since acir_tests was first designed. The idea of passing BIN and FLOW and mix and matching just makes no sense anymore. There isn't REALLY more than one choice of BIN, soon bbjs wont fill that role at all and already has drifted. We just are explicit on our cases and make a script for each - there really aren't that many! As well many of the accumulated flows were low value. also, clean up unused bb cli flags like --recursive and --honk_recursion, some old api stuff that is now e.g. done in acir_tests like making Prover.toml's for recursive tests Closes AztecProtocol/barretenberg#1326.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Mocking for translator and eccvm proofs (#16368)
refactor: cleanup acir_tests and unused bb cli commands (#16361)
END_COMMIT_OVERRIDE