feat: Mocking for translator and eccvm proofs#16368
Merged
federicobarbacovi merged 14 commits intomerge-train/barretenbergfrom Aug 15, 2025
Merged
feat: Mocking for translator and eccvm proofs#16368federicobarbacovi merged 14 commits intomerge-train/barretenbergfrom
federicobarbacovi merged 14 commits intomerge-train/barretenbergfrom
Conversation
federicobarbacovi
force-pushed
the
fb/mock_translator_eccvm_proofs
branch
from
283ead9 to
c8a8abf
Compare
| /** | ||
| * @brief Check that the size of a mock merge proof matches expectation | ||
| */ | ||
| TEST_F(IvcRecursionConstraintTest, MockMergeProofSize) |
Contributor
Author
There was a problem hiding this comment.
Duplicate test
Contributor
There was a problem hiding this comment.
where's the other occurrence?
Contributor
Author
There was a problem hiding this comment.
Sorry, I should have pointed this out:
kashbrti
reviewed
Aug 14, 2025
barretenberg/cpp/src/barretenberg/dsl/acir_format/mock_verifier_inputs.cpp
Outdated
Show resolved
Hide resolved
kashbrti
reviewed
Aug 14, 2025
| // Sumcheck multilinear evaluations | ||
| for (size_t i = 0; i < Flavor::NUM_ALL_ENTITIES; ++i) { | ||
| proof.emplace_back(FF::random_element()); | ||
| populate_field_elements(proof, Flavor::NUM_ALL_ENTITIES); |
kashbrti
reviewed
Aug 14, 2025
barretenberg/cpp/src/barretenberg/dsl/acir_format/mock_verifier_inputs.cpp
Show resolved
Hide resolved
kashbrti
reviewed
Aug 14, 2025
| { | ||
| // Construct a Honk proof as the concatenation of an Oink proof and a Decider proof | ||
| HonkProof oink_proof = create_mock_oink_proof<Flavor, PublicInputs>(); | ||
| HonkProof oink_proof = create_mock_oink_proof<Flavor, PublicInputs>(inner_public_inputs_size); |
Contributor
There was a problem hiding this comment.
again a nitpick, why are we calling these inner_public_inputs?
Contributor
Author
There was a problem hiding this comment.
Added an explanation for the parameter. They are the pub inputs coming from ACIR.
kashbrti
reviewed
Aug 14, 2025
barretenberg/cpp/src/barretenberg/dsl/acir_format/mock_verifier_inputs.cpp
Outdated
Show resolved
Hide resolved
kashbrti
reviewed
Aug 14, 2025
| builder.set_variable(key_fields[offset++].witness_index, public_inputs_size); | ||
| // Third key field is the pub inputs offset | ||
| size_t num_inner_public_inputs = public_inputs_size - IO::PUBLIC_INPUTS_SIZE; | ||
| uint32_t pub_inputs_offset = NativeFlavor::has_zero_row ? 1 : 0; |
Contributor
There was a problem hiding this comment.
thanks for cleaning up the mess I created here :D
kashbrti
approved these changes
Aug 15, 2025
Contributor
kashbrti
left a comment
kashbrti
left a comment
There was a problem hiding this comment.
LGTM. nice work! It would be good if @ledwards2225 takes a final look because he probably has more context on what exactly had to be done.
Will run CI full because the VK generation might be affected by this I think.
ledwards2225
approved these changes
Aug 15, 2025
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
Nice! Looks like maybe some more code sharing could be done but maybe you tried and found there are quirks that prevent it.
barretenberg/cpp/src/barretenberg/dsl/acir_format/mock_verifier_inputs.cpp
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/dsl/acir_format/mock_verifier_inputs.cpp
Show resolved
Hide resolved
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
* Define methods to mock proofs for translator and eccvm * Restructure functions to create dummy vk and proofs in recursion constraints so that they use the functions from `mock_verifier_inputs` (this avoids code duplication) This PR is mostly in preparation for transitioning the tube in noir. We need to mock translator and eccvm proofs to mock ClientIVC proofs. --------- Co-authored-by: AztecBot <tech@aztecprotocol.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mock_verifier_inputs(this avoids code duplication)This PR is mostly in preparation for transitioning the tube in noir. We need to mock translator and eccvm proofs to mock ClientIVC proofs.