fix: requiring blake3 inputs to have less than 1024 bytes

barretenberg/cpp/src/barretenberg/crypto/blake3s/CMakeLists.txt

@@ -1 +1 @@
-barretenberg_module(crypto_blake3s)
+barretenberg_module(crypto_blake3s common)

barretenberg/cpp/src/barretenberg/crypto/blake3s/blake3s.tcc

@@ -32,6 +32,7 @@
 #include <iostream>
 #include <type_traits>
 
+#include "barretenberg/common/assert.hpp"
 #include "blake3s.hpp"
 
 namespace blake3 {
@@ -240,6 +241,8 @@ constexpr void blake3_hasher_finalize(const blake3_hasher* self, uint8_t* out)
 
 std::vector<uint8_t> blake3s(std::vector<uint8_t> const& input)
 {
+    ASSERT(input.size() <= 1024, "Barretenberg does not support blake3s with input lengths greater than 1024 bytes.");
+
     blake3_hasher hasher;
     blake3_hasher_init(&hasher);
     blake3_hasher_update(&hasher, static_cast<const uint8_t*>(input.data()), input.size());

barretenberg/cpp/src/barretenberg/crypto/blake3s/blake3s.test.cpp

@@ -414,3 +414,9 @@ TEST(MiscBlake3s, TestVectors)
         static_assert(result_constexpr == v.output);
     });
 }
+
+TEST(MiscBlake3s, TooLargeInputTest)
+{
+    std::vector<uint8_t> input(1025, 0);
+    EXPECT_DEATH(blake3::blake3s(input), "Assertion failed");
+}

barretenberg/cpp/src/barretenberg/crypto/blake3s_full/blake3s.cpp

@@ -865,7 +865,6 @@ std::vector<uint8_t> blake3s(std::vector<uint8_t> const& input,
     // Initialize the hasher.
     blake3_hasher hasher;
     blake3_hasher_init(&hasher);
-
     switch (mode_id) {
     case HASH_MODE:
         blake3_hasher_init(&hasher);

barretenberg/cpp/src/barretenberg/dsl/acir_format/blake3_constraint.cpp

@@ -27,7 +27,7 @@ template <typename Builder> void create_blake3_constraints(Builder& builder, con
 
         // XXX: The implementation requires us to truncate the element to the nearest byte and not bit
         auto num_bytes = round_to_nearest_byte(num_bits);
-
+        ASSERT(num_bytes <= 1024, "barretenberg does not support blake3 inputs with more than 1024 bytes");
         field_ct element = to_field_ct(witness_index, builder);
         byte_array_ct element_bytes(element, num_bytes);
 

barretenberg/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp

@@ -246,6 +246,8 @@ using namespace blake3_internal;
 
 template <typename Builder> byte_array<Builder> blake3s(const byte_array<Builder>& input)
 {
+    ASSERT(input.size() <= 1024, "Barretenberg does not support blake3s with input lengths greater than 1024 bytes.");
+
     if constexpr (HasPlookup<Builder>) {
         return blake3s_plookup::blake3s<Builder>(input);
     }

barretenberg/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.test.cpp

@@ -48,3 +48,14 @@ TEST(stdlib_blake3s, test_double_block_plookup)
     bool proof_result = CircuitChecker::check(builder);
     EXPECT_EQ(proof_result, true);
 }
+
+TEST(stdlib_blake3s, test_too_large_input_plookup)
+{
+    auto builder = UltraBuilder();
+
+    std::vector<uint8_t> input_v(1025, 0);
+
+    byte_array_plookup input_arr(&builder, input_v);
+    EXPECT_DEATH(stdlib::blake3s(input_arr),
+                 "Barretenberg does not support blake3s with input lengths greater than 1024 bytes.");
+}

barretenberg/noir/bb_proof_verification/src/lib.nr

@@ -1,6 +1,6 @@
 // Constants for UltraHonk recursive verifier inputs
 pub global PROOF_TYPE_HONK: u32 = 1; // identifier for UltraHonk verfier
-pub global RECURSIVE_PROOF_LENGTH: u32 = 456; 
+pub global RECURSIVE_PROOF_LENGTH: u32 = 456;
 pub global HONK_VERIFICATION_KEY_LENGTH_IN_FIELDS: u32 = 112;
 
 pub type UltraHonkProof = [Field; RECURSIVE_PROOF_LENGTH];
@@ -10,7 +10,8 @@ pub type UltraHonkVerificationKey = [Field; HONK_VERIFICATION_KEY_LENGTH_IN_FIEL
 pub global PROOF_TYPE_ROLLUP_HONK: u32 = 5; // identifier for rollup-UltraHonk verfier
 pub global IPA_CLAIM_SIZE: u32 = 10;
 pub global IPA_PROOF_LENGTH: u32 = 69;
-pub global RECURSIVE_ROLLUP_HONK_PROOF_LENGTH: u32 = RECURSIVE_PROOF_LENGTH + IPA_CLAIM_SIZE + IPA_PROOF_LENGTH;
+pub global RECURSIVE_ROLLUP_HONK_PROOF_LENGTH: u32 =
+    RECURSIVE_PROOF_LENGTH + IPA_CLAIM_SIZE + IPA_PROOF_LENGTH;
 pub global ROLLUP_HONK_VERIFICATION_KEY_LENGTH_IN_FIELDS: u32 = 113;
 
 pub type RollupHonkProof = [Field; RECURSIVE_ROLLUP_HONK_PROOF_LENGTH];