fix: requiring blake3 inputs to have less than 1024 bytes #14628
Merged
fix: requiring blake3 inputs to have less than 1024 bytes #14628
Conversation
Contributor
|
Maybe worth adding this assertion in barretenberg as well? |
suyash67
reviewed
Jun 3, 2025
|
|
||
| template <typename Builder> byte_array<Builder> blake3s(const byte_array<Builder>& input) | ||
| { | ||
| ASSERT(input.size() <= 1024, "Barretenberg does not support blake3s with input lengths greater than 1024 bytes."); |
Contributor
There was a problem hiding this comment.
nice! Could you please also add tests that trigger this ASSERT for completeness? You probably need to use EXPECT_DEATH for such a test, see this test for example.
suyash67
reviewed
Jun 3, 2025
|
|
||
| std::vector<uint8_t> blake3s(std::vector<uint8_t> const& input) | ||
| { | ||
| ASSERT(input.size() <= 1024, "Barretenberg does not support blake3s with input lengths greater than 1024 bytes."); |
Contributor
There was a problem hiding this comment.
Can you add a test here as well that triggers this ASSERT?
Contributor
Author
There was a problem hiding this comment.
This was actually not building. Since this is outside stdlib, I decided to change it to an error throw and catch it in the test.
…/aztec-packages into kb/blake3_1024_range_limit
kashbrti
commented
Jun 5, 2025
| pub global IPA_PROOF_LENGTH: u32 = 69; | ||
| pub global RECURSIVE_ROLLUP_HONK_PROOF_LENGTH: u32 = RECURSIVE_PROOF_LENGTH + IPA_CLAIM_SIZE + IPA_PROOF_LENGTH; | ||
| pub global RECURSIVE_ROLLUP_HONK_PROOF_LENGTH: u32 = | ||
| RECURSIVE_PROOF_LENGTH + IPA_CLAIM_SIZE + IPA_PROOF_LENGTH; |
Contributor
Author
There was a problem hiding this comment.
the formatter just made these changes
suyash67
approved these changes
Jun 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #12517
also see: noir-lang/noir#8690