chore(rollup): add function to trigger seed snapshot for next epoch#13910
Merged
chore(rollup): add function to trigger seed snapshot for next epoch#13910
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
approved these changes
Apr 29, 2025
Contributor
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
The setupSampleSeed.tree is empty but otherwise neat.
LHerskind
requested changes
Apr 30, 2025
| contract SetupSampleSeedTest is ValidatorSelectionTestBase { | ||
| function test_setupSampleSeed(uint16 _epochToTest) public setup(4) { | ||
| // Check that the epoch is not set | ||
| bound(_epochToTest, 2, type(uint16).max); |
Contributor
There was a problem hiding this comment.
The bound is not actually used, you it returns a value so we can run into just throwing in 0 and then we end up underflowing further down
Maddiaa0
force-pushed
the
md/seed-snapshot-trigger
branch
from
174ecc1 to
52e33e8
Compare
LHerskind
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds cli arg to set the seed for the next epoch, much cheaper than performing the whole sampling