feat(sol): remove committee storage#13700
Merged
just-mitch merged 65 commits intonextfrom May 27, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
force-pushed
the
md/seed-snapshots
branch
from
49ab911 to
4321429
Compare
Maddiaa0
force-pushed
the
md/commit-comittee
branch
from
d0029e1 to
aa5c621
Compare
Maddiaa0
force-pushed
the
md/commit-comittee
branch
from
aa5c621 to
585fc62
Compare
Maddiaa0
force-pushed
the
md/commit-comittee
branch
from
cecd46b to
033536f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 27, 2025
fixes: #13581 --------- Co-authored-by: LHerskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Mitch <mitchell@aztecprotocol.com> Co-authored-by: Mitchell Tracy <mitchellftracy@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2025
Fixes #14287 Atm it is only addressing the solidity part, since a good chunk of the node and such is going to get touched and same will happen with #13700 so we are going to keep this one pending until that it is since it seems like the less painful to deal with. --------- Co-authored-by: Mitch <mitchell@aztecprotocol.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
Fixes multiple `Rollup__InvalidArchive` errors that were popping up on tests since #13700. Example from [this run](http://ci.aztec-labs.com/c82b760acf321da6): ``` 09:42:54 [09:42:54.569] VERBOSE: sequencer Unable to build/enqueue block Rollup__InvalidArchive(0x2fdc940e38cff0a9fd112204b3ad9b7e75c3efaf9495dd7aeaecbcc8d2bba20f, 0x18674a63a7dd5a173cff9633512b7e5bd6b5536ea0b7c96929dcc68473c31e45) ``` The cause for this was the removal of the `canProposeAtNextEthBlock` check [here](https://github.com/AztecProtocol/aztec-packages/pull/13700/files#diff-1c2150b6e6b122e3a184b1132b8d6946e4e27fefe53381035810638fabcebe9cL384). This call to the rollup contract was removed since we were now manually checking the proposer using the epoch cache (which is a good thing!), but we lost the check for the latest archive root. This meant that, if the sequencer started building _before_ the archiver was caught up to the previous block, it would build off an older chain tip, and only get rejected during block publishing. Note that in an actual setting, it should actually fail to collect attestations, since the proposal should be deemed invalid by validators due to a wrong parent, but most of our e2e tests don't have a committee. This PR makes the sequencer check that the archiver has synched to the previous L1 block before proceeding. Note that L1 missed slots would cause issues here, but we can address that when we get to #[14766](#14766). In addition, this PR restores the early call to `canProposeAtNextEthBlock` to be on the safe side before we start building.
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
Fixes multiple `Rollup__InvalidArchive` errors that were popping up on tests since AztecProtocol#13700. Example from [this run](http://ci.aztec-labs.com/c82b760acf321da6): ``` 09:42:54 [09:42:54.569] VERBOSE: sequencer Unable to build/enqueue block Rollup__InvalidArchive(0x2fdc940e38cff0a9fd112204b3ad9b7e75c3efaf9495dd7aeaecbcc8d2bba20f, 0x18674a63a7dd5a173cff9633512b7e5bd6b5536ea0b7c96929dcc68473c31e45) ``` The cause for this was the removal of the `canProposeAtNextEthBlock` check [here](https://github.com/AztecProtocol/aztec-packages/pull/13700/files#diff-1c2150b6e6b122e3a184b1132b8d6946e4e27fefe53381035810638fabcebe9cL384). This call to the rollup contract was removed since we were now manually checking the proposer using the epoch cache (which is a good thing!), but we lost the check for the latest archive root. This meant that, if the sequencer started building _before_ the archiver was caught up to the previous block, it would build off an older chain tip, and only get rejected during block publishing. Note that in an actual setting, it should actually fail to collect attestations, since the proposal should be deemed invalid by validators due to a wrong parent, but most of our e2e tests don't have a committee. This PR makes the sequencer check that the archiver has synched to the previous L1 block before proceeding. Note that L1 missed slots would cause issues here, but we can address that when we get to #[14766](AztecProtocol#14766). In addition, this PR restores the early call to `canProposeAtNextEthBlock` to be on the safe side before we start building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #13581